655483 - List available features in testserver.pl

Status: ASSIGNED

(Bugzilla :: Installation & Upgrading, enhancement)

Description

[Frédéric Buclin]

Attachment: patch, v1

testserver.pl tests whether your installation is working correctly. I think it's a nice place to list available features too.

Comment 1

[Max Kanat-Alexander]

Comment on attachment 530835 [details] [diff] [review]
patch, v1

Cool idea. :-) I think check_features_installed should be in Bugzilla::Install::Requirements. (Also, there's some refactoring of that file in the FastCGI patch that I should pull out and apply before you do this, because it will make your code a lot easier, I think.)

Also, do you think maybe this output should be in checksetup.pl instead? Although checksetup.pl does have a lot of output already.

Comment 2

[Frédéric Buclin]

(In reply to comment #1)
> Also, do you think maybe this output should be in checksetup.pl instead?
> Although checksetup.pl does have a lot of output already.

Yeah, I don't think checksetup.pl is the right place for this code. Its output is already big enough. I think it's better to keep this code for testserver.pl so that the admin can check how his installation behaves *after* the installation is complete, if he wants to.

Comment 3

[Frédéric Buclin]

We are going to branch for Bugzilla 4.4 next week and this bug is either too invasive to be accepted for 4.4 at this point or shows no recent activity. The target milestone is reset and will be set again *only* when a patch is attached and approved.

I ask the assignee to reassign the bug to the default assignee if you don't plan to work on this bug in the near future, to make it clearer which bugs should be fixed by someone else.

Comment 4

[Sunil Joshi [:sjoshi]]

Attachment: Patch-v1

Moved the function to Bugzilla::Install::Requirements.

Not sure what mkanat meant by "FastCGI patch that I should pull out and apply before you do this.."

Comment 5

[Simon Green]

Comment on attachment 785108 [details] [diff] [review]
Patch-v1

Review of attachment 785108 [details] [diff] [review]:
-----------------------------------------------------------------

::: Bugzilla/Install/Requirements.pm
@@ +785,5 @@
> +
> +    # Populate the cache.
> +    Bugzilla->feature('patch_viewer');
> +
> +    foreach my $feature (sort keys %{Bugzilla->request_cache->{feature_map}}) {

I'm not happy getting this from the cache. It should come directly from the B::I::R file

e.g.
sort uniq map { @{$_->{feature}} } @{&OPTIONAL_MODULES}

Feel free to split the above line out if you want (also requires uniq from List::MoreUtils)

It also means you don't need to use the two populate lines above this one.