655827 - Multiple failed unit tests in test-context-menu.

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect)

Description

[Matěj Cepl]

Attachment: test log from cfx testall -v

See attached log for detail, but aside from our friend test-windows.testActiveWindow (bug 614079), there are some test-context-menu tests failing (with 472797a29).

The following tests failed:
  test-windows.testActiveWindow: failure
  test-context-menu.testPageContextMatch: failure
  test-context-menu.testURLContextNoMatch: failure
  test-context-menu.testMultipleContexts: timed out
  test-context-menu.testRemoveContext: failure
  test-context-menu.testMultipleModulesAdd: failure
  test-context-menu.testMultipleModulesAddOverflow: failure
  test-context-menu.testMultipleModulesDiffContexts1: failure

Comment 1

[Myk Melez [:myk] [@mykmelez]]

I think Brian is going to back out the offending patch.

Comment 2

[Brian Warner [:warner :bwarner]]

Reverted in https://github.com/mozilla/addon-sdk/commit/c65f3f7ff9e3abb658b889f4df4b28dcd5fed96c

Be careful when re-applying: see the comments in that commit for hints.

Comment 3

[Matěj Cepl]

(In reply to comment #2)
> Reverted in
> https://github.com/mozilla/addon-sdk/commit/
> c65f3f7ff9e3abb658b889f4df4b28dcd5fed96c
> 
> Be careful when re-applying: see the comments in that commit for hints.

That's IMHO wrong advice. Proper way is to let users just merge this commit and when you want to reapply fixed branch, also revert this revert (see Linus' advice in the mail you linked to). So that, we would merge it again without knowing (or need to know) some revert happened.