655863 - Port |Bug 581475 - nsContextMenu cleanup|

Status: RESOLVED FIXED

(SeaMonkey :: UI Design, defect)

Description

[Ian Neal]

Attachment: Port the two sets of fixes patch v1.0

A certain amount of clean up was done in Bug 581475 for Firefox and Bug 425575 fixed an issue to do with large context menus.
This patch ports those fixes across to SM.

Comment 1

[[e-mail]]

I could never reproduce the STR for bug 425575...

Comment 2

[Philip Chee]

I can reproduce Bug 425575 with SeaMonkey 2.0 but not with SeaMonkey 2.1pre or  Firefox 4.0.2pre. I assume that some backend change (probably the mouse handling code) fixed this without needing the front end wallpaper.

Comment 3

[Dão Gottwald [:dao]]

Firefox 4 has the workaround from bug 425575.

Comment 4

[Ian Neal]

(In reply to comment #2)
> I can reproduce Bug 425575 with SeaMonkey 2.0 but not with SeaMonkey 2.1pre
> or  Firefox 4.0.2pre. I assume that some backend change (probably the mouse
> handling code) fixed this without needing the front end wallpaper.

Having done some further testing, bug 425575 only seems to exist on SM2.0 under Windows, other platforms on SM2.0 don't have the bug and SM2.1 doesn't have the bug at all. I'll respin without that part in the patch.

Comment 5

[Ian Neal]

Attachment: Port the one set of fixes patch v1.1 [Checked in: Comment 7]

Changes since v1.0:
* Removes the fix from bug 425575 as it does not appear to be needed against moz-2.0 and above.

Comment 6

[[e-mail]]

Comment on attachment 531454 [details] [diff] [review]
Port the one set of fixes patch v1.1 [Checked in: Comment 7]

>+    if (aNode.namespaceURI == xulNS ||
>+        this.isTargetAFormControl(aNode)) {
Please update the comment for this function to match.

Comment 7

[Ian Neal]

Comment on attachment 531454 [details] [diff] [review]
Port the one set of fixes patch v1.1 [Checked in: Comment 7]

http://hg.mozilla.org/comm-central/rev/910bed11ccfc