The default bug view has changed. See this FAQ.

Aurora: password field is not masked immediately and shows artifacts, when typing past the end of the field

VERIFIED FIXED in Firefox 5

Status

Fennec Graveyard
General
P4
critical
VERIFIED FIXED
6 years ago
3 years ago

People

(Reporter: nhirata, Assigned: stechz)

Tracking

Firefox 5
Firefox 5
ARM
Android

Details

(URL)

Attachments

(3 attachments, 6 obsolete attachments)

34.70 KB, image/png
Details
8.86 KB, patch
roc
: review+
Details | Diff | Splinter Review
31.21 KB, image/png
Details
Aurora Branch:
Mozilla/5.0 (Android; Linux armv71; rv5.0a2) Gecko/20110509 Firefox/5.0a2 Fennec/5.0a2
Device: Thunderbolt
OS: Android 2.2

1. go to http://reader.google.com
2. select the password field and type

Expected: the typing should get masked with a *
Actual: you can see the original letters being typed

Note:
1. the login doesn't look so great, esp if you type pass the boundary which also happens on the nightly.
tracking-fennec: --- → 5+
tracking-firefox5: --- → ?
status-firefox5: --- → affected
Version: Trunk → Firefox 5
Keywords: regressionwindow-wanted

Updated

6 years ago
tracking-firefox5: ? → ---
Created attachment 531784 [details]
screenshot

I'm not sure why but the downloads from 2011-05-10-05-mozilla-aurora-android-r7/ doesn't show the issue, but the downloads from today latest-mozilla-aurora-android-r7/ does show the issue.  I had downloaded from the alias on 05/09.

Attached is a screenshot of what I see.  Is it a build issue?
(Assignee)

Comment 2

6 years ago
That looks like the password field isn't getting invalidated for some reason.
(Assignee)

Comment 3

6 years ago
This is not reproducing for me from a freshly checked out copy of aurora. Does this happen on Desktop?
For what it's worth, this is marked as Aurora but I can reproduce in 4.0.1
I could not reproduce this in 4.0.1, Aurora, or Nightly using an HTC T-Mobile G2 with Android 2.2, using either the stock Android keyboard or Swype.
Need to keep typing past the field length in order to repro the issue.
(Assignee)

Updated

6 years ago
Assignee: nobody → ben
Keywords: regressionwindow-wanted
Sorry, to clarify what I'm seeing looks like this http://i.imgur.com/HwKyG.png -- mine will mask after a delay .. Naoki, does yours eventually mask?
Yes, Aaron, mine eventually masks after a 2 to 3 second delay.
Okay, I can reproduce this when typing past the end of the field in Aurora.

Given that this occurs in more limited circumstances than we first thought, and that the password does mask after a few seconds, this probably doesn't need to be a "hardblocker" for Fennec 5.
Summary: Aurora : The password field is not masked when trying to type in your password → Aurora: password field is not masked immediately and shows artifacts, when typing past the end of the field
(Assignee)

Comment 10

6 years ago
Created attachment 532374 [details] [diff] [review]
(aurora patch) Password field is not masked immediately and shows artifacts, when typing past the end of the field
Attachment #532374 - Flags: review?(roc)
(Assignee)

Comment 11

6 years ago
Roc, moving the info layer to below the overflow clip fixes this problem. I'm not really sure why. My best theory is that the info layer got in the way of clip overflow flattening, causing the invalidation to not happen properly.
(Assignee)

Comment 12

6 years ago
Created attachment 532380 [details] [diff] [review]
(trunk patch) Password field is not masked immediately and shows artifacts, when typing past the end of the field
Attachment #532380 - Flags: review?(roc)
Comment on attachment 532374 [details] [diff] [review]
(aurora patch) Password field is not masked immediately and shows artifacts, when typing past the end of the field

Review of attachment 532374 [details] [diff] [review]:
-----------------------------------------------------------------
Attachment #532374 - Flags: review?(roc) → review+
Comment on attachment 532380 [details] [diff] [review]
(trunk patch) Password field is not masked immediately and shows artifacts, when typing past the end of the field

Review of attachment 532380 [details] [diff] [review]:
-----------------------------------------------------------------
Attachment #532380 - Flags: review?(roc) → review+

Updated

6 years ago
Keywords: checkin-needed
(Assignee)

Updated

6 years ago
Attachment #532374 - Flags: approval-mozilla-aurora?
(Assignee)

Comment 15

6 years ago
Back to the drawing board. This patch effectively disables asynchronous scrolling for scroll frames altogether, so that's why it fixed the bug...
(Assignee)

Updated

6 years ago
Attachment #532374 - Attachment is obsolete: true
Attachment #532374 - Flags: approval-mozilla-aurora?
(Assignee)

Updated

6 years ago
Attachment #532380 - Attachment is obsolete: true

Updated

6 years ago
Keywords: checkin-needed
(Assignee)

Comment 16

6 years ago
Created attachment 533048 [details] [diff] [review]
(aurora patch) Password field is not masked immediately and shows artifacts, when typing past the end of the field
Attachment #533048 - Flags: review?(roc)
Comment on attachment 533048 [details] [diff] [review]
(aurora patch) Password field is not masked immediately and shows artifacts, when typing past the end of the field

Review of attachment 533048 [details] [diff] [review]:
-----------------------------------------------------------------

I think FrameLayerBuilder::DisplayItemDataEntry::HasContainerLayer also has to be modified to ignore your scroll info layers, preferably by capturing the ACTIVE_EMPTY state and storing it in the DisplayItemData.
(Assignee)

Comment 18

6 years ago
Created attachment 533096 [details] [diff] [review]
(aurora patch) Password field is not masked immediately and shows artifacts, when typing past the end of the field
(Assignee)

Comment 19

6 years ago
Created attachment 533097 [details] [diff] [review]
(aurora patch) Password field is not masked immediately and shows artifacts, when typing past the end of the field

Not sure if this is more satisfactory, but I tried something different and
checked if the bit flag is set. This looks similar to what FrameLayerBuilder
does in StoreNewDisplayItemData so I thought it might work. Let me know if I
need to do this as per your suggestion.
Attachment #533097 - Flags: review?(roc)
(Assignee)

Updated

6 years ago
Attachment #533048 - Attachment is obsolete: true
Attachment #533048 - Flags: review?(roc)
(Assignee)

Updated

6 years ago
Attachment #533096 - Attachment is obsolete: true
(Assignee)

Comment 20

6 years ago
Created attachment 533111 [details] [diff] [review]
Password field is not masked immediately and shows artifacts, when typing past the end of the field

After talking on IRC, I now understand the above strategy wouldn't work because
the real issue is that the container layer flag will never get unset.
Attachment #533111 - Flags: review?(roc)
(Assignee)

Updated

6 years ago
Attachment #533097 - Attachment is obsolete: true
Attachment #533097 - Flags: review?(roc)
Comment on attachment 533111 [details] [diff] [review]
Password field is not masked immediately and shows artifacts, when typing past the end of the field

Review of attachment 533111 [details] [diff] [review]:
-----------------------------------------------------------------

r+ with those fixed

::: layout/base/FrameLayerBuilder.cpp
@@ +443,4 @@
>  {
>    for (PRUint32 i = 0; i < mData.Length(); ++i) {
> +    if (mData[i].mLayer->GetType() == Layer::TYPE_CONTAINER &&
> +        mData[i].mIsEmptyLayer)

!mData[i].mIsEmptyLayer, surely?

@@ +1382,5 @@
>        InvalidateForLayerChange(item, ownLayer);
>  
>        mNewChildLayers.AppendElement(ownLayer);
> +      mBuilder->LayerBuilder()->AddLayerDisplayItem(
> +        ownLayer, item, layerState == LAYER_ACTIVE_EMPTY);

Better to just pass in layerState directly. Boolean parameters suck!
Attachment #533111 - Flags: review?(roc) → review-
In particular, instead of mIsEmptyLayer, just store the layer state and check it in HasNonEmptyContainerLayer.
(Assignee)

Comment 23

6 years ago
Created attachment 533296 [details] [diff] [review]
Password field is not masked immediately and shows artifacts, when typing past the end of the field
Attachment #533296 - Flags: review?(roc)
(Assignee)

Updated

6 years ago
Attachment #533111 - Attachment is obsolete: true
Comment on attachment 533296 [details] [diff] [review]
Password field is not masked immediately and shows artifacts, when typing past the end of the field

Review of attachment 533296 [details] [diff] [review]:
-----------------------------------------------------------------

::: layout/base/FrameLayerBuilder.h
@@ +225,5 @@
>     * Record aItem as a display item that is rendered by aLayer.
>     */
> +  void AddLayerDisplayItem(Layer* aLayer,
> +                           nsDisplayItem* aItem,
> +                           LayerState aLayerState = LAYER_ACTIVE);

Don't use a default parameter here, just pass it explicitly everywhere.
Attachment #533296 - Flags: review?(roc) → review+
(Assignee)

Comment 25

6 years ago
Pushed http://hg.mozilla.org/mozilla-central/rev/9024deba23fe
(Assignee)

Updated

6 years ago
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
(Assignee)

Updated

6 years ago
Attachment #533296 - Flags: approval-mozilla-beta?
Attachment #533296 - Flags: approval-mozilla-aurora?
Target Milestone: --- → Firefox 6
Comment on attachment 533296 [details] [diff] [review]
Password field is not masked immediately and shows artifacts, when typing past the end of the field

If I understand our current branch status, this will be merged onto aurora next week automatically because you've landed it on trunk.

I'll approve for beta after a couple days of baking on trunk
Attachment #533296 - Flags: approval-mozilla-aurora?

Comment 27

6 years ago
What's the potential fall-out for Desktop if we take this into Beta?
Extremely low since desktop doesn't create LAYER_ACTIVE_EMPTY layers.

Comment 29

6 years ago
I can also see a similar behavior on Fennec 5.0b2 mainly when typing in the username field from login pages.

Build ID: Mozilla /5.0 (Android;Linux armv7l;rv:5.0) Gecko/20110517 Firefox/5.0 Fennec/5.0

See screenshot.

Comment 30

6 years ago
Created attachment 533662 [details]
Straight lines between characters
Anna, can you update to the 19th build please to see if you see the same issue?
the 19th build should have fixed it.  I've checked with:

Mozilla/5.0 (Android; Linux armv71; rv6.0a1) Gecko/20110519 Firefox/6.0a1 Fennec/6.0a1
Device: Droid 2 
OS: Android 2.2

Mozilla/5.0 (Android; Linux armv71; rv6.0a1) Gecko/20110519 Firefox/6.0a1 Fennec/6.0a1
Device: Thunderbolt
OS: Android 2.2

Comment 32

6 years ago
Yes, it seems to be fixed on the nightly build (on the 19th build).

But, Naoki, isn't it supposed to be fixed on Beta too ? I could see this issue happening quite frequently even though unfortunately I could not reproduce it 100%.
(Assignee)

Comment 33

6 years ago
Anna, this is currently not fixed on Beta. Once this bug is verified for nightly and we have approval, we can push it to the beta branch and make a new beta build.
(Assignee)

Comment 34

6 years ago
Oops, I somehow overwrote VERIFIED!

Comment 35

6 years ago
Comment on attachment 533296 [details] [diff] [review]
Password field is not masked immediately and shows artifacts, when typing past the end of the field

Would be nice to have someone from mobile in these triage meetings. Approving because this doesn't impact desktop.
Attachment #533296 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

Comment 36

6 years ago
Comment on attachment 533296 [details] [diff] [review]
Password field is not masked immediately and shows artifacts, when typing past the end of the field

Please land this change on both Aurora and Beta. (In the future, getting changes in during Aurora will save you this extra step.)
Attachment #533296 - Flags: approval-mozilla-aurora+
(In reply to comment #35)
> Comment on attachment 533296 [details] [diff] [review] [review]
> Password field is not masked immediately and shows artifacts, when typing
> past the end of the field
As I said in comment 26, I'd like this to bake for a few days. IMO this shouldn't land on beta until next week.

> Would be nice to have someone from mobile in these triage meetings.
> Approving because this doesn't impact desktop.
Where/when was the beta triage call announced? Probably better to answer that on irc or something.

Comment 38

6 years ago
VERIFIED FIXED on:

Mozilla /5.0 (Android;Linux armv7l;rv:6.0a1) Gecko/20110523 Firefox/6.0a1 Fennec/6.0a1 


Mozilla /5.0 (Android;Linux armv7l;rv:5.0a2) Gecko/20110522 Firefox/5.0a2 Fennec/5.0a2 

Device: HTC Desire Z (Android 2.2)
Status: RESOLVED → VERIFIED

Comment 39

6 years ago
Did this land on beta? I ask because comment 38 implies it did.
Yes: http://hg.mozilla.org/releases/mozilla-beta/rev/c04ad1e37383
status-firefox5: affected → fixed
Target Milestone: Firefox 6 → Firefox 5

Updated

6 years ago
status-firefox6: --- → fixed
You need to log in before you can comment on or make changes to this bug.