655883 - Additional keyboard shortcuts for moving through unstarred failures

Status: RESOLVED FIXED

(Tree Management Graveyard :: TBPL, defect)

Description

[Steve Fink [:sfink] [:s:]]

'j' and 'k' seem to be the default keyboard shortcut keys for moving through items in a list in most of the programs I use. I find them nicer to use because they make sense positionally rather than using the English spelling of 'n'ext and 'p'rev.

Comment 1

[Steve Fink [:sfink] [:s:]]

Attachment: Bind 'j' and 'k' keys to move through unstarred failures

This patch binds 'j' and 'k', and also adds a "keymap" because extending the conditional just seemed way too ugly.

Comment 2

[Arpad Borsos [:Swatinem]]

Comment on attachment 531198 [details] [diff] [review]
Bind 'j' and 'k' keys to move through unstarred failures

Review of attachment 531198 [details] [diff] [review]:
-----------------------------------------------------------------

I don’t think you need strict equality checks (===) here. Nice patch! ;-)

Comment 3

[Steve Fink [:sfink] [:s:]]

http://hg.mozilla.org/users/mstange_themasta.com/tinderboxpushlog/rev/e00ac8cb2704