655997 - Crash when changing the orientation from portrait to landscape or vice versa

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect, P1)

Description

[Andreea Pod]

Attachment: crash message

Mozilla /5.0 (Android;Linux armv7l;rv:6.0a1) Gecko/201105010 Firefox/6.0a1 Fennec/6.0a1 
Device: LG Optimus 2X (Android 2.2)

Steps to reproduce:
1. Open Fennec 
2. Change the orientation

Expected result:
The application should work with no problem

Actual result:
Fennec crashes "The application Fennec(process org.mozilla.fennec) has stopped unexpectedly. Please try again."

Note: 
You can see the attached screenshot and log.

Comment 1

[Andreea Pod]

Attachment: crash log

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to comment #1)
> Created attachment 531309 [details]
> crash log

I don't see a crash in the log. Does the crash happen for other phones too?

Comment 3

[Aaron Train [:aaronmt]]

Able to reproduce with same build, Nexus One

http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=dfcfa00eb188&tochange=e0f6db50231f

Comment 4

[Aaron Train [:aaronmt]]

05-10 09:23:43.070: ERROR/AndroidRuntime(4485): java.lang.RuntimeException: Unable to resume activity {org.mozilla.fennec/org.mozilla.fennec.App}: java.lang.NullPointerException

Comment 5

[Aaron Train [:aaronmt]]

Attachment: Null pointer crash log

Comment 6

[Aaron Train [:aaronmt]]

http://mxr.mozilla.org/mozilla-central/source/embedding/android/GeckoApp.java#373

Looks like bug 643032 with changeset http://hg.mozilla.org/mozilla-central/rev/33992b8ef80e

Comment 7

[Aaron Train [:aaronmt]]

No idea why a rotation triggers this, weird

Comment 8

[Matt Brubeck (:mbrubeck)]

Attachment: patch

Oops, we need to move the initialization *above* the early return in onCreate, so it's re-created whenever the activity is.

Comment 9

[Matt Brubeck (:mbrubeck)]

http://hg.mozilla.org/mozilla-central/rev/24bd5f86695c

Comment 10

[Aaron Train [:aaronmt]]

Verified fixed:
Mozilla/5.0 (Android; Linux armv7l; rv:6.0a1) Gecko/20110511 Firefox/6.0a1 Fennec/6.0a1