656055 - Configure fails to properly parse registry settings for DirectX-SDK path under Windows/XP

Status: RESOLVED DUPLICATE of bug 643732

(Firefox Build System :: General, defect)

Description

[Bill Gianopoulos [:WG9s]]

Attachment: fix

Evidently, 'reg query' under Windows/XP uses TABs as delimiters.  The code in configure to parse the installpath for the DirectX-SDK assumes it will be one or more spaces.

Comment 1

[Benoit Jacob [:bjacob] (mostly away)]

dupe of bug 643732. I would be very interested in knowing whether the patch in bug 648804 fixes it, as it makes it no longer rely on spaces-vs-tabs.

Comment 2

[Bill Gianopoulos [:WG9s]]

(In reply to comment #1)
> dupe of bug 643732. I would be very interested in knowing whether the patch
> in bug 648804 fixes it, as it makes it no longer rely on spaces-vs-tab

It will probably take me until the weekend to have time to test this, but I will be happy to do so.

Comment 3

[Benoit Jacob [:bjacob] (mostly away)]

Oh -- didn't see that you attached a patch here. Sorry.

But we need the patch in bug 648804 anyway. Can you try it?

Of course both patches can be merged. If the patch in bug 648804 doesn't fix the issue on WinXP, one can merge the regex from your patch into it.

Comment 4

[Bill Gianopoulos [:WG9s]]

(In reply to comment #3)
> Oh -- didn't see that you attached a patch here. Sorry.
> 
> But we need the patch in bug 648804 anyway. Can you try it?
> 
> Of course both patches can be merged. If the patch in bug 648804 doesn't fix
> the issue on WinXP, one can merge the regex from your patch into it.

This was really a very simpleminded replace all TABs with spaces before doing the other substitution for multiple spaces to a single space etc.

Comment 5

[Benoit Jacob [:bjacob] (mostly away)]

On the other hand my patch looks for the first occurence of [a-zA-Z]:\ and interprete that as the beginning of the path.

I'm happy with anything that works.