656097 - make "does not exist" warning in file viewer friendlier

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Admin/Editor Tools, enhancement, P5)

Description

[Wil Clouser [:clouserw]]

Right now the warning says something like "content/findinnumbers.css does not exist in file 48935."  I'm suggesting we make that "$file does not exist in the older version" or "...the newer version".  Even if that is just comparing which number is bigger.  What do you think?

Comment 1

[Andy McKay]

I like that. Thinking I really should just show a whole pile of + or - instead though.

Comment 2

[Wil Clouser [:clouserw]]

(In reply to comment #1)
> I like that. Thinking I really should just show a whole pile of + or -
> instead though.

I like that even better, too!

Comment 3

[krupa raj[:krupa]]

Also, we need to think of a way to show deleted files in the file differ.

Comment 4

[Andy McKay]

Deleted files are show in a second tree (if present) below the first tree. 

https://github.com/jbalogh/zamboni/commit/b7a38434034fceb7d20e5103b9ecdb9b5c5b1925
https://github.com/jbalogh/zamboni/commit/d60b5dce7a80c57430aff3b00083eb3b4d658e35

Comment 5

[Andy McKay]

Showing the different search engine file as a deleted file.

Comment 6

[Andy McKay]

https://github.com/jbalogh/zamboni/commit/7b5ac5e

Comment 7

[krupa raj[:krupa]]

verified fixed @ https://addons.allizom.org/en-US/firefox/files/compare/119615...79034/file/install.rdf#top

Comment 8

[krupa raj[:krupa]]

Attachment: post-fix screenshot