65610 - File | Edit Page fails

Status: VERIFIED FIXED

(Core :: DOM: Editor, defect, P1)

Description

[Charles Manske]

Open a new window in Composer.
Open a Browser, then use Edit Page.
We are failing in nsEditorShell.cpp::CheckOpenWindowForURLMatch().

Comment 1

[Charles Manske]

*** Bug 65590 has been marked as a duplicate of this bug. ***

Comment 2

[Charles Manske]

*** Bug 65590 has been marked as a duplicate of this bug. ***

Comment 3

[John Unruh]

*** Bug 65611 has been marked as a duplicate of this bug. ***

Comment 4

[Kathleen :Brade]

moving over severity "blocker" from bug #65590.



This *is* a blocker since I can't edit a page directly from the browser or from 

Open Web Location (File menu).  Or perhaps there is *another* bug that is 

preventing anything from working in the editor?  I can't type in a newly created 

Composer window either.  :-(

Comment 5

[Charles Manske]

There's actually 2 problems here:
1: An error in XUL to not supply the "launchWindow"
2. Error in nsEditorShell.cpp to not work when URL is not "file://" type.
I'll attach diffs.
Blake or Kathy: Would please review them?

Comment 6

[Charles Manske]

Attachment: Fix for XPFE part of problem.

Comment 7

[Charles Manske]

Attachment: Fix for nsEditorShell part of problem

Comment 8

[Charles Manske]

Changing summary -- didn't accurately describe problem.

Comment 9

[Charles Manske]

Attachment: Includes fix for side-effect problem that editor won't load!

Comment 10

[Charles Manske]

Attachment: A better XPFE fix includes context menu fix

Comment 11

[Kathleen :Brade]

xpfe changes look fine to me; not sure about the editor changes yet (I don't need 
them to fix the problems I see)

Comment 12

[Blake Ross]

r=blake
Please fix the indentation and style to match the rest of the file (hey, that 
rhymes).

Comment 13

[Charles Manske]

Attachment: Minimal fix for not failing if URL is not "file:"

Comment 14

[Charles Manske]

checked in.

Comment 15

[Tracy Walker [:tracy]]

marking verified with commercial builds 
windows 2001-01-17-06-mtrunk
linux 2001-01-17-06-mtrunk