656113 - Sort out alignment of the text in the edit contact dialog on the message header

Status: RESOLVED FIXED

(Thunderbird :: Message Reader UI, defect)

Description

[Mark Banner (:standard8)]

The alignment of the text for the values of name/email/address book (and the note about contacts in mailing lists) doesn't look quite right.

Blake said he's going to try and sort these out.

Comment 1

[Alex Ihrig [:Thunderbird_Mail_DE]]

At Windows 7 the yellow star in the edit panel looks compressed, if the mailing list text is shown.

Comment 2

[Blake Winton (:bwinton) (:☕️)]

I'm not really working on these, so I'm freeing them up for a community member to take.
(Filter on [ossifrage] to delete all the notifications.)

Comment 3

[Thomas D. (:thomas8)]

Attachment: Screenshot 1: Labels and content mismatch due to vertical alignment fail

Maybe the general assumption is that nobody is using mailing lists because they are flawed?

9 years later, and we still get THIS when clicking on blue star in primary message reader UI.

Richard? (what would we do without you!??)

Comment 4

[Richard Marti (:Paenglab)]

Attachment: 656113-editContactPanel-grid.patch

The two vbox don't align properly when the description is shown. I converted them to a grid.

Comment 5

[Magnus Melin [:mkmelin]]

Comment on attachment 9167987 [details] [diff] [review]
656113-editContactPanel-grid.patch

Review of attachment 9167987 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thx! r=mkmelin

Comment 6

[Thomas D. (:thomas8)]

Awesome, thank you Richard!

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/658a49b14bd6
Use a grid in the editContactPanel. r=mkmelin

Comment 8

[Geoff Lankow (:darktrojan)]

We have to get you running tests, Richard. I caught one failure with this patch before I landed it.

Comment 9

[Richard Marti (:Paenglab)]

Attachment: 656113-editContactPanel-grid.patch

Patch with the test fixed by Geoff.

[Approval Request Comment]
User impact if declined: wrongly aligned labels
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): low

Comment 10

[Wayne Mery (:wsmwk)]

Comment on attachment 9168405 [details] [diff] [review]
656113-editContactPanel-grid.patch

[Triage Comment]
Approved for beta

Comment 11

[Rob Lemley [:rjl]]

Thunderbird 80.0b2:
https://hg.mozilla.org/releases/comm-beta/rev/7acaed666b89

Comment 12

[Wayne Mery (:wsmwk)]

Comment on attachment 9168405 [details] [diff] [review]
656113-editContactPanel-grid.patch

[Triage Comment]
Approved for esr78

Comment 13

[Geoff Lankow (:darktrojan)]

Thunderbird 78.1.2:
https://hg.mozilla.org/releases/comm-esr78/rev/7e3477790630