656118 - Facebook Redirect Bug

Status: VERIFIED FIXED

(Websites :: donate.mozilla.org, defect)

Description

[raymond [:retornam] (inactive)]

STR:
1) On http://www-stage.mozilla.org/join/thankyou.en.html click  the Facebook button
2) After sharing on Facebook user is redirected to https://donate.mozilla.org/page/contribute/protect-the-web


Expected Result:
1) The user should be redirected to http://www-stage.mozilla.org/join/thankyou.en.html

Comment 1

[Stephen Donner [:stephend] Not actively reading bugmail]

Paul: who should fix this blocker bug?

Comment 2

[Paul Osman [:paulosman]]

(In reply to comment #1)
> Paul: who should fix this blocker bug?

Assigning to Devin from Crowd Favorite. 

Devin, can you take a look at this one?

Comment 3

[Devin Reams (Crowd Favorite)]

This is a Facebook-application-level setting (not in the code). As this app ID is in use both in production and staging we will not be changing the URL in the application.

If desire is now to change pre-existing behavior (Jane?) to redirect back to the thank you page and not the application URL (mozilla.org/join) we can update accordingly but is OOS.

Additionally, a separate staging App can be created.

Comment 4

[Jane Finette]

Devin -- is this how we had this set up before? I dont remember discussing this before.

Comment 5

[Devin Reams (Crowd Favorite)]

Nothing here has changed since the original implementation. We can remove the redirection entirely so the user remains on the page if desired (likely the best user experience in case they still needed to print their card).

Comment 6

[Jane Finette]

Agreed with Devin - I don't think a redirect is needed and it's the best user experience. Thanks (and to you William for your feedback over the desk!)

Comment 7

[Devin Reams (Crowd Favorite)]

No problemo, after looking into it a bit more, we've simply yanked the redirect from thankyou.php and sent a pull request to Paul to stage/confirm.

(marking resolved, assuming that's the right workflow step here, correct me if wrong)

Comment 8

[raymond [:retornam] (inactive)]

reopening as it is still not working on  stage

Comment 9

[Devin Reams (Crowd Favorite)]

Paul, when you get a moment would you mind pushing the latest change to www-stage please so Raymond can test/confirm? Thanks in advance.

Comment 10

[Paul Osman [:paulosman]]

(In reply to comment #9)
> Paul, when you get a moment would you mind pushing the latest change to
> www-stage please so Raymond can test/confirm? Thanks in advance.

Committed to SVN. Should be on staging in ~15 min.

Comment 11

[Devin Reams (Crowd Favorite)]

Hey all, we couldn't help but notice the redirect is still in place.

http://join.mozilla.org/thankyou.en.html

Paul had stage updated here on Weds:

http://www-stage.mozilla.org/join/thankyou.en.html

Please let us know if you have any other questions or changes. Otherwise, feel free to coordinate the testing/push to prod.

(also see bug #656398)

Comment 12

[raymond [:retornam] (inactive)]

verified fixed http://www-stage.mozilla.org/join/thankyou.en.html