Change testOpenAndCloseAddonManager.js to use locally served content

RESOLVED FIXED

Status

Mozilla QA
Mozmill Tests
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: davehunt, Assigned: davehunt)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [mozmill-endurance])

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

7 years ago
The testOpenAndCloseAddonManager.js endurance test currently uses the live Add-ons Manager content, which has two negative effects: The duration/success of the test is dependent on the network connection, and an endurance test with lots of iterations is essentially an attack on the site.

We need to change this test to use locally served content.
(Assignee)

Comment 1

7 years ago
Created attachment 531597 [details] [diff] [review]
Change testOpenAndCloseAddonManager.js to use locally served content. v1
Assignee: nobody → dave.hunt
Attachment #531597 - Flags: review?(anthony.s.hughes)
(Assignee)

Comment 2

7 years ago
Created attachment 531598 [details] [diff] [review]
Change testOpenAndCloseAddonManager.js to use locally served content. v1

Replacing patch attached by mistake.
Attachment #531597 - Attachment is obsolete: true
Attachment #531597 - Flags: review?(anthony.s.hughes)
Attachment #531598 - Flags: review?(anthony.s.hughes)
Comment on attachment 531598 [details] [diff] [review]
Change testOpenAndCloseAddonManager.js to use locally served content. v1

Review of attachment 531598 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good -- assuming this has been tested across all platforms, r+.
Attachment #531598 - Flags: review?(anthony.s.hughes) → review+
(Assignee)

Updated

7 years ago
Attachment #531598 - Flags: review?(hskupin)
Comment on attachment 531598 [details] [diff] [review]
Change testOpenAndCloseAddonManager.js to use locally served content. v1

>+const AMO_DISCOVER_URL = 'extensions.webservice.discoverURL';

We should add this constant to the addons.js module.

>+  prefs.preferences.setPref(AMO_DISCOVER_URL, LOCAL_TEST_PAGE);

When you set this pref, you will have to reset it after the test has been finished.
Attachment #531598 - Flags: review?(hskupin) → review-
(Assignee)

Comment 5

7 years ago
Created attachment 532829 [details] [diff] [review]
Change testOpenAndCloseAddonManager.js to use locally served content. v1.1

(In reply to comment #4)
> Comment on attachment 531598 [details] [diff] [review] [review]
> Change testOpenAndCloseAddonManager.js to use locally served content. v1
> 
> >+const AMO_DISCOVER_URL = 'extensions.webservice.discoverURL';
> 
> We should add this constant to the addons.js module.

Done.

> >+  prefs.preferences.setPref(AMO_DISCOVER_URL, LOCAL_TEST_PAGE);
> 
> When you set this pref, you will have to reset it after the test has been
> finished.

Done.
Attachment #531598 - Attachment is obsolete: true
Attachment #532829 - Flags: review?(hskupin)
Attachment #532829 - Flags: review?(hskupin) → review+
Keywords: checkin-needed
(Assignee)

Comment 6

7 years ago
I don't currently have commit access (I have submitted a request). Could you land this one Henrik? Thanks.
Landed as:
http://hg.mozilla.org/qa/mozmill-tests/rev/30e33e0718bf (default)
http://hg.mozilla.org/qa/mozmill-tests/rev/5da14115b425 (aurora)
http://hg.mozilla.org/qa/mozmill-tests/rev/c107db423c11 (2.0)
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Also pushed to beta which I have had missed last time:
http://hg.mozilla.org/qa/mozmill-tests/rev/675e8dce8e88
Depends on: 658255
You need to log in before you can comment on or make changes to this bug.