656349 - Sync Setup error dialog appears when bypassing easy setup

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Tony Chung [:tchung]]

Attachment: cannot setup sync screenshot

The Cannot Setup Sync error dialog appears immediately if bypassing easy setup code.   See screenshot

Repro:
1) install android nightly build on phone or tablet: Mozilla/5.0 (Android; Linux armv71; rv:6.0a1) Gecko/20110511 Firefox/6.0a1 Fennec/6.0a1
2) Prefs > Sync > Click Connect (assuming no account setup yet)
3) Easy setup dialog appears.  wait for code to show
4) Click "I'm not near my computer..." link
5) Verify Cannot setup dialog pops up immediately, then asking user to try again.

Expected:
- Cannot setup sync dialog shoudlnt appear since user didnt change anything yet

Actual:
- error dialog popup

Comment 1

[Matt Brubeck (:mbrubeck)]

Can't reproduce this in Aurora (Firefox 5).

Comment 2

[Matt Brubeck (:mbrubeck)]

Regression from bug 649739.

Comment 3

[Matt Brubeck (:mbrubeck)]

Attachment: patch

The JPAKE client code now sends "jpake.error.userabort" instead of (null) when the user cancels the connection process.

Comment 4

[Matt Brubeck (:mbrubeck)]

http://hg.mozilla.org/mozilla-central/rev/5b483355806f

Comment 5

[Tony Chung [:tchung]]

Verified fix on nightly: Mozilla/5.0 (Android; Linux armv71; rv:6.0a1) Gecko/20110516 Firefox/6.0a1 Fennec/6.0a1