Closed
Bug 656371
Opened 13 years ago
Closed 13 years ago
remove org.mozilla.fennec hardcodes
Categories
(Release Engineering :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: bear, Assigned: bear)
References
Details
(Whiteboard: [android][tegra])
Attachments
(4 files, 8 obsolete files)
4.57 KB,
patch
|
mozilla
:
review+
bear
:
checked-in+
|
Details | Diff | Splinter Review |
7.35 KB,
patch
|
mozilla
:
review+
bear
:
checked-in+
|
Details | Diff | Splinter Review |
8.39 KB,
patch
|
mozilla
:
review+
bear
:
checked-in+
|
Details | Diff | Splinter Review |
5.76 KB,
patch
|
mozilla
:
review+
bear
:
checked-in+
|
Details | Diff | Splinter Review |
tracking bug for the removal of all places in sut_tools and buildbotcustom where org.mozilla.fennec is hardcodeed
Assignee | ||
Updated•13 years ago
|
Assignee: nobody → bear
Whiteboard: [android][tegra]
Assignee | ||
Comment 1•13 years ago
|
||
Attachment #531710 -
Flags: feedback?(aki)
Assignee | ||
Comment 2•13 years ago
|
||
Attachment #531711 -
Flags: feedback?(aki)
Comment 3•13 years ago
|
||
Comment on attachment 531710 [details] [diff] [review] buildbot-configs change for branch based process names buildbotcustom.steps.talos.MozillaUpdateConfig has the branchName, so this should work with some logic there. I believe mozilla-beta is org.mozilla.firefox_beta and we'll need to add mozilla-release -> org.mozilla.firefox .
Attachment #531710 -
Flags: feedback?(aki) → feedback+
Comment 4•13 years ago
|
||
Comment on attachment 531711 [details] [diff] [review] change remote talos to use processName and add remoteExtras to remote unittests This looks right, but where does the unit test factory get the remote extras from ? (Needs a config patch?)
Attachment #531711 -
Flags: feedback?(aki) → feedback+
Assignee | ||
Comment 5•13 years ago
|
||
(In reply to comment #4) > Comment on attachment 531711 [details] [diff] [review] [review] > change remote talos to use processName and add remoteExtras to remote > unittests > > This looks right, but where does the unit test factory get the remote extras > from ? (Needs a config patch?) yea, i'm still chewing on it but wanted to get it to you for feedback to make sure I wasn't driving off the road with this change
Assignee | ||
Comment 6•13 years ago
|
||
add remoteExtras bit for unittests
Attachment #531710 -
Attachment is obsolete: true
Attachment #531889 -
Flags: feedback?(aki)
Assignee | ||
Comment 7•13 years ago
|
||
Attachment #531711 -
Attachment is obsolete: true
Attachment #531890 -
Flags: feedback?(aki)
Comment 8•13 years ago
|
||
Comment on attachment 531889 [details] [diff] [review] buildbot-configs change for branch based process names Review of attachment 531889 [details] [diff] [review]: ----------------------------------------------------------------- ::: mozilla-tests/config.py @@ +13,5 @@ > +REMOTE_PROCESS_NAMES = { 'default': 'org.mozilla.fennec', > + 'mozilla-beta': 'org.mozilla.fennec_beta', > + 'mozilla-aurora': 'org.mozilla.fennec_aurora', > + } > + mozilla-beta == org.mozilla.firefox_beta
Assignee | ||
Comment 9•13 years ago
|
||
(In reply to comment #8) > Comment on attachment 531889 [details] [diff] [review] [review] > buildbot-configs change for branch based process names > > Review of attachment 531889 [details] [diff] [review] [review]: > ----------------------------------------------------------------- > > ::: mozilla-tests/config.py > @@ +13,5 @@ > > +REMOTE_PROCESS_NAMES = { 'default': 'org.mozilla.fennec', > > + 'mozilla-beta': 'org.mozilla.fennec_beta', > > + 'mozilla-aurora': 'org.mozilla.fennec_aurora', > > + } > > + > > mozilla-beta == org.mozilla.firefox_beta changed - thanks for catching that
Comment 10•13 years ago
|
||
Comment on attachment 531889 [details] [diff] [review] buildbot-configs change for branch based process names (In reply to comment #3) > I believe mozilla-beta is org.mozilla.firefox_beta and we'll need to add > mozilla-release -> org.mozilla.firefox . As Joel noted, this is still true. Looks like this will work, though.
Attachment #531889 -
Flags: feedback?(aki) → feedback+
Updated•13 years ago
|
Attachment #531890 -
Flags: feedback?(aki) → feedback+
Assignee | ||
Updated•13 years ago
|
Attachment #531889 -
Flags: review?(aki)
Assignee | ||
Updated•13 years ago
|
Attachment #531890 -
Flags: review?(aki)
Comment 11•13 years ago
|
||
Comment on attachment 531890 [details] [diff] [review] change remote talos to use processName and add remoteExtras to remote unittests Needs testing, but I think this may work.
Attachment #531890 -
Flags: review?(aki) → review+
Comment 12•13 years ago
|
||
Comment on attachment 531889 [details] [diff] [review] buildbot-configs change for branch based process names r=me with the org.mozilla.fennec_beta -> org.mozilla.firefox_beta change and 'mozilla-release': 'org.mozilla.firefox',
Attachment #531889 -
Flags: review?(aki) → review+
Assignee | ||
Comment 13•13 years ago
|
||
currently being tested on staging for both m-c and m-a sendchanges
Attachment #533032 -
Flags: review?(aki)
Comment 14•13 years ago
|
||
Comment on attachment 533032 [details] [diff] [review] changes to cleanup.py and installApp.py to work with new process names >+processNames = [ 'org.mozilla.fennec', >+ 'org.mozilla.fennec_aurora', >+ 'org.mozilla.fennec_beta', As noted several times above, this should be org.mozilla.firefox_beta and you should add 'org.mozilla.firefox'. >+ #status = dm.updateApp(target, processName=processName, ipAddr=proxyIP, port=proxyPort) >+ #if status is not None and status: >+ # print "updateApp() call returned %s" % status >+ status = dm.installApp(target) We haltOnFailure on cleanup.py, so not uninst'ing first is fine here. >- pid = dm.processExist('org.mozilla.fennec') >+ pid = dm.processExist(processName) > print 'org.mozilla.fennec PID', pid NIT: maybe |print %s PID' % processName, pid| ? Marking r- to get your attention about firefox_beta :)
Attachment #533032 -
Flags: review?(aki) → review-
Assignee | ||
Comment 15•13 years ago
|
||
Attachment #533032 -
Attachment is obsolete: true
Attachment #533041 -
Flags: review?(aki)
Comment 16•13 years ago
|
||
Comment on attachment 533041 [details] [diff] [review] changes to cleanup.py and installApp.py to work with new process names Thanks Bear!
Attachment #533041 -
Flags: review?(aki) → review+
Assignee | ||
Comment 17•13 years ago
|
||
fixed list of processNames and also brought it up to date with what I had tweaked while testing on staging
Attachment #531889 -
Attachment is obsolete: true
Attachment #533677 -
Flags: review?(aki)
Assignee | ||
Comment 18•13 years ago
|
||
added the processName parameter to remote mochitest as well as the original list, fixed a couple bugs found while doing staging tests
Attachment #531890 -
Attachment is obsolete: true
Attachment #533679 -
Flags: review?(aki)
Updated•13 years ago
|
Attachment #533677 -
Flags: review?(aki) → review+
Updated•13 years ago
|
Attachment #533679 -
Flags: review?(aki) → review+
Assignee | ||
Comment 19•13 years ago
|
||
Comment on attachment 533679 [details] [diff] [review] change remote talos to use processName and add remoteExtras to remote unittests committed changeset 1539:4faac6e54f22
Attachment #533679 -
Flags: checked-in+
Assignee | ||
Comment 20•13 years ago
|
||
Comment on attachment 533677 [details] [diff] [review] buildbot-configs change for branch based process names committed changeset 4124:05feb881375c
Attachment #533677 -
Flags: checked-in+
Assignee | ||
Comment 21•13 years ago
|
||
Comment on attachment 533041 [details] [diff] [review] changes to cleanup.py and installApp.py to work with new process names committed changeset 1434:7d95d5f68756
Attachment #533041 -
Flags: checked-in+
Assignee | ||
Comment 22•13 years ago
|
||
Attachment #535000 -
Flags: review?(aki)
Comment 23•13 years ago
|
||
Comment on attachment 535000 [details] [diff] [review] bustage fix - use lower case branch name to search dictionary As mentioned in IRC, branchName is actually the name of the tinderbox page; we should pass in branch from generateTalosBranchObjects. And ugh.
Attachment #535000 -
Flags: review?(aki) → review-
Assignee | ||
Comment 24•13 years ago
|
||
Attachment #535000 -
Attachment is obsolete: true
Attachment #535092 -
Flags: review?(aki)
Updated•13 years ago
|
Attachment #535092 -
Flags: review?(aki) → review+
Assignee | ||
Comment 25•13 years ago
|
||
staging caught that I missed one location that needs the proper processname - the MozillaUpdateConfig() call for talos.
Attachment #535092 -
Attachment is obsolete: true
Attachment #535148 -
Flags: review?(aki)
Assignee | ||
Comment 26•13 years ago
|
||
Attachment #535148 -
Attachment is obsolete: true
Attachment #535148 -
Flags: review?(aki)
Attachment #535152 -
Flags: review?(aki)
Updated•13 years ago
|
Attachment #535152 -
Flags: review?(aki) → review+
Assignee | ||
Comment 27•13 years ago
|
||
Comment on attachment 535152 [details] [diff] [review] bustage fix - use proper branch name for talos test runs committed changeset 1555:3f888fb91eda
Attachment #535152 -
Flags: checked-in+
Assignee | ||
Comment 28•13 years ago
|
||
reconfig landed - marking as fixed
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Updated•11 years ago
|
Product: mozilla.org → Release Engineering
You need to log in
before you can comment on or make changes to this bug.
Description
•