Update KNOWN_LANGUAGES on dev, stage and prod

VERIFIED FIXED in 1.0

Status

VERIFIED FIXED
7 years ago
7 years ago

People

(Reporter: stas, Assigned: stas)

Tracking

({l12y})

Firefox 4

Details

Attachments

(1 attachment)

(Assignee)

Description

7 years ago
I'd like to update the KNOWN_LANGUAGES setting on dev, stage and prod.

On dev:

KNOWN_LANGUAGES = (
    'en-US',
    'ar',
    'ca',
    'de',
    'el',
    'es-ES',
    'fr',
    'fy-NL',
    'gl',
    'id',
    'ja',
    'ko',
    'nl',
    'pl',
    'pt-BR',
    'sl',
    'sq',
    'zh-TW',
)

On stage and prod:

KNOWN_LANGUAGES = (
    'en-US',
    'de',
    'es-ES',
    'fy-NL',
    'ja',
    'nl',
    'pl',
    'sq',
    'zh-TW',
)

What do you think the best process is to make these changes?  Should one of these go into settings.py and other one into settings_local on the respective box?

Also, there will likely be more changes coming to these settings depending on the work done by the localizers.  Ideally, I'd like to be able to make changes to KNOWN_LANGUAGES until Monday, May 16th.  Is this doable?  Should I file new bugs for every change?

Thanks!
(Assignee)

Comment 1

7 years ago
I pushed https://github.com/mozilla/markup/commit/5ad1bc98076f5f46e9586d1de3e95ee08430e50b with the dev-ready value.

I'll try to figure out what to do with prod tomorrow.
Target Milestone: --- → 1.0
Blocks: 628811
(Assignee)

Updated

7 years ago
Keywords: l12y
(Assignee)

Updated

7 years ago
Assignee: nobody → stas
(Assignee)

Comment 2

7 years ago
Created attachment 532389 [details] [diff] [review]
Proposed patch

The idea behind this patch, as discussed with Gandalf, is to change the following line

> KNOWN_LANGUAGES = KNOWN_LANGUAGES_DEV

to

> KNOWN_LANGUAGES = KNOWN_LANGUAGES_PROD

on the production server, locally, in the settings.py file.  Unfortunately, we can't put this into settings_local.py, as KNOWN_LANGUAGES need to be defined earlier than we import settings_local.

Assuming the _PROD list will change, are we risking merge conflicts from git pull?  It's just a couple of lines away.  Would IT be OK with a `git stash && git pull && git stash pop` workflow?
Attachment #532389 - Flags: review?(ozten.bugs)
Attachment #532389 - Flags: feedback?(gandalf)
Comment on attachment 532389 [details] [diff] [review]
Proposed patch

Review of attachment 532389 [details] [diff] [review]:
-----------------------------------------------------------------

::: ffdemo/settings.py
@@ +85,5 @@
> +    'zh-TW',
> +)
> +
> +KNOWN_LANGUAGES = KNOWN_LANGUAGES_DEV
> +

please, put this line further away from KNOWN_LANGUAGES_PROD (which we know will change) to avoid merge conflicts
Attachment #532389 - Flags: feedback?(gandalf) → feedback+

Comment 4

7 years ago
Comment on attachment 532389 [details] [diff] [review]
Proposed patch

This eats up too much memory! r-

Just kidding. Great idea! Thanks Stas.
Attachment #532389 - Flags: review?(ozten.bugs) → review+
(Assignee)

Comment 5

7 years ago
Thanks :)

Landed in https://github.com/mozilla/markup/commit/caeee76c0fb6a6eb122c49527fece539752e2243.

Leaving the bug open to adjust these settings one last time before the 1.0 push.
(Assignee)

Comment 6

7 years ago
I filed bug 657112 to deal with changing the value of KNOWN_LANGUAGES to KNOWN_LANGUAGES_PROD on production after the 1.0 push.
(Assignee)

Comment 7

7 years ago
Closing this bug in favor of bug 657475 which gandalf filed, which has better-defined steps.
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Closing this bug as QA verified per stas's note in comment 7.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.