Note: There are a few cases of duplicates in user autocompletion which are being worked on.

Skip dummy frames for function.caller

RESOLVED FIXED

Status

()

Core
JavaScript Engine
RESOLVED FIXED
6 years ago
4 years ago

People

(Reporter: mrbkap, Assigned: mrbkap)

Tracking

Trunk
x86_64
Linux
Points:
---

Firefox Tracking Flags

(firefox5+ wontfix)

Details

(Whiteboard: fixed-in-tracemonkey)

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Created attachment 531764 [details] [diff] [review]
Patch

Normally this isn't necessary, but for an upcoming patch, I need to have a dummy frame in the same compartment as the current compartment. The dummy frame isn't really a "caller", so we should skip it.
Attachment #531764 - Flags: review?(luke)
(Assignee)

Comment 1

6 years ago
Please pretend that I named the new StackFrame* variable "callerframe" so it doesn't conflict with the JSObject "caller" inside the if statement.

I also made a getCompartment -> compartment renaming while I was there.

Updated

6 years ago
Attachment #531764 - Flags: review?(luke) → review+
(Assignee)

Comment 2

6 years ago
http://hg.mozilla.org/tracemonkey/rev/2453a6adb500
Whiteboard: fixed-in-tracemonkey
(Assignee)

Comment 3

6 years ago
Note that the patch that landed was slightly different than the patch attached here...

Asking for tracking-firefox5 as this is a prerequisite for bug 650273.
tracking-firefox5: --- → ?

Updated

6 years ago
tracking-firefox5: ? → +
cdleary-bot mozilla-central merge info:
http://hg.mozilla.org/mozilla-central/rev/2453a6adb500
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Comment on attachment 531764 [details] [diff] [review]
Patch

Please land this patch to mozilla-beta.
Attachment #531764 - Flags: approval-mozilla-beta+

Comment 6

6 years ago
I don't see this in mozilla-beta yet and we're starting to run out of runway. Please land ASAP. Thanks.

Comment 7

6 years ago
Comment on attachment 531764 [details] [diff] [review]
Patch

pulling back approval and not going to try to fix for Firefox 5.
Attachment #531764 - Flags: approval-mozilla-beta+ → approval-mozilla-beta-

Updated

6 years ago
status-firefox5: --- → wontfix
You need to log in before you can comment on or make changes to this bug.