Closed Bug 656460 Opened 9 years ago Closed 9 years ago

Skip dummy frames for function.caller

Categories

(Core :: JavaScript Engine, defect)

x86_64
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
Tracking Status
firefox5 + wontfix

People

(Reporter: mrbkap, Assigned: mrbkap)

References

Details

(Whiteboard: fixed-in-tracemonkey)

Attachments

(1 file)

Attached patch PatchSplinter Review
Normally this isn't necessary, but for an upcoming patch, I need to have a dummy frame in the same compartment as the current compartment. The dummy frame isn't really a "caller", so we should skip it.
Attachment #531764 - Flags: review?(luke)
Please pretend that I named the new StackFrame* variable "callerframe" so it doesn't conflict with the JSObject "caller" inside the if statement.

I also made a getCompartment -> compartment renaming while I was there.
Attachment #531764 - Flags: review?(luke) → review+
Note that the patch that landed was slightly different than the patch attached here...

Asking for tracking-firefox5 as this is a prerequisite for bug 650273.
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Comment on attachment 531764 [details] [diff] [review]
Patch

Please land this patch to mozilla-beta.
Attachment #531764 - Flags: approval-mozilla-beta+
I don't see this in mozilla-beta yet and we're starting to run out of runway. Please land ASAP. Thanks.
Comment on attachment 531764 [details] [diff] [review]
Patch

pulling back approval and not going to try to fix for Firefox 5.
Attachment #531764 - Flags: approval-mozilla-beta+ → approval-mozilla-beta-
You need to log in before you can comment on or make changes to this bug.