656508 - multiple imports of jsobjects for no reason

Status: RESOLVED FIXED

(Testing Graveyard :: Mozmill, defect)

Description

[Jeff Hammel]

https://github.com/mozautomation/mozmill/blob/master/jsbridge/jsbridge/network.py#L103

jsobjects is imported twice.  WHY?  After the first import, there is
no additional action nor a separate namespacing (it is
module-global). It is looked up in sys.modules after the first
import.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Updated location is:

https://github.com/mozilla/mozmill/blob/master/jsbridge/jsbridge/network.py#L72

We should also move this to the top of the file.

Comment 2

[Berker Peksag [:berkerpeksag]]

I've opened a pull request for this bug:

https://github.com/mozilla/mozmill/pull/113

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Berker, thanks for your interest in working on that bug. Would you mind to attach a patch here instead of opening pull requests? We would appreciate that. Thanks.

Comment 4

[Berker Peksag [:berkerpeksag]]

Attachment: Remove duplicate import of "jsobjects" module.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Comment on attachment 700654 [details] [diff] [review]
Remove duplicate import of "jsobjects" module.

Review of attachment 700654 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. I will get it checked-in in a moment. Thanks a lot even it was a trivial one. If you want to help with another bug feel free to look out for one or come back to me.

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+2]]

https://github.com/mozilla/mozmill/commit/6d677f0c80970f25b3e3fd8fd7e5816b28d61a07