656511 - Read package name from install.rdf in upload XPI feature

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Add-on Builder, defect, P2)

Description

[krupa raj[:krupa]]

Attachment: test jetpack

steps to reproduce:
1. Log into  AMO Builder and load https://builder.addons.mozilla.org/user/dashboard/
2. Click on 'Upload XPI'
3. Upload the attached jetpack

expected behavior:
Upload is successful. If upload is unsuccessful, user is shown a meaningful  error message.

observed behavior:
Uploading an xpi return s a 403. Page says 'Wrong file'

[17:33:44.051] POST https://builder.addons.mozilla.org/addon/new/upload_xpi/ [HTTP/1.1 403 FORBIDDEN 3005ms]

Comment 1

[krupa raj[:krupa]]

Attachment: screenshot

Comment 2

[krupa raj[:krupa]]

screencast: http://screencast.com/t/0ZERHlkFH

Comment 3

[Piotr Zalewa [:zalun]]

Thanks for the report - taking a look.

Comment 4

[Piotr Zalewa [:zalun]]

The issue is that for uploading a XPI it has to be renamed as the field in package.json (the name field). In this case renaming "bobloblaw-1108.xpi" to "save-your-facebook-content.xpi" will solve the issue.

I consider this as a workaround. I've got already a solution for this and it's gonna be fixed in the next cycle of updates.

I am renaming the bug.

Comment 5

[Piotr Zalewa [:zalun]]

It is possible we will have to remove the entire feature.

Comment 6

[Daniel Buchner [:dbuc]]

Can you elaborate on this new commen, what changed? I ask only because your last comment seemed much more optimistic :)

Comment 7

[Piotr Zalewa [:zalun]]

As David said on the meeting last time - it's a decompiler. 
We will probably not know the exact hierarchy within the XPI and it might and will change to be more complicated to extract the exact packages which were used to create the XPI.
It might change to import a zipped directory of packages with hierarchy written in package.json files.

Comment 8

[Daniel Buchner [:dbuc]]

Given that, I would pull the feature for now, just remove it from the view.

Comment 9

[Piotr Zalewa [:zalun]]

Upload XPI feature removed from sight
https://github.com/zalun/FlightDeck/commit/c11649df74ffa68cdf0d2f5675c8c74ec40160bb