656632 - jsbridge JSONEncoder copy+pastes from simplejson code

Status: RESOLVED INVALID

(Testing Graveyard :: Mozmill, defect)

Description

[Jeff Hammel]

https://github.com/mozautomation/mozmill/blob/master/jsbridge/jsbridge/network.py#L109

It shouldn't.  Instead, it should just call the code it wants to call:

def _iterencode(self, o, markers=None):
        if isinstance(o, jsobjects.JSObject):
            yield o._name_
        else:
            yield simplejson.JSONEncoder._iterencode(self, o, markers)

Comment 1

[Berker Peksag [:berkerpeksag]]

Attachment: Patch v1

Comment 2

[Berker Peksag [:berkerpeksag]]

Attachment: Patch v2

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Jeff filed this bug and he better understands the underlying code to be the mentor here.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Comment on attachment 720264 [details] [diff] [review]
Patch v2

Jeff, can you please review and land if it looks fine to you? Thanks.

Comment 5

[Jeff Hammel]

pushed: https://github.com/mozilla/mozmill/commit/29c68aa5e36f6d2f14eda42a1a315c1f45564497

Thanks for the patch!

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+1]]

The landing of this patch caused us troubles with Mozmill 2.0 on OS X 10.6 with Python 2.6 installed. It's a hard-blocker for us to get that release out. Reverting the changes here will stop that behavior, so I will go ahead and backout the landing of this patch.

Berker, would you be interested in working on a cleaner solution, which will work even under the platform specs as given above?

Backed out:
https://github.com/mozilla/mozmill/commit/d86ae556d654bf6277462f52ce2fb6707f976939 (master)
https://github.com/mozilla/mozmill/commit/cd4ef346e2691697a71c0e6757d726d81e9fbc7a (hotfix-2.0)

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+1]]

With bug 940035 we have removed the usage of simplejson from Mozmill. So the patch as attached on this bug is no longer necessary.