656633 - JS Bridge connects twice

Status: RESOLVED WONTFIX

(Testing Graveyard :: Mozmill, defect)

Description

[Jeff Hammel]

First in Telnet's __init__ then in the Bridge's __init__:

https://github.com/mozautomation/mozmill/blob/master/jsbridge/jsbridge/network.py#L57

https://github.com/mozautomation/mozmill/blob/master/jsbridge/jsbridge/network.py#L170

We shouldn't need to connect more than once.  If we do need to connect
more than once for some tricky reason, it should be documented

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

The location of the repository has been changed. So here the updated references:

https://github.com/mozilla/mozmill/blob/master/jsbridge/jsbridge/network.py#L26
https://github.com/mozilla/mozmill/blob/master/jsbridge/jsbridge/network.py#L102

Comment 2

[Manish Goregaokar [:manishearth]]

Anvesh, this is a simpler bug if you want it.

Comment 3

[Subhendu Ghosh]

Hi, I wish to fix this bug. Please guide me through the process.

Comment 4

[Manish Goregaokar [:manishearth]]

Assigned. We'll wait for @whimboo to comment on this, but in the meantime have a look at the duplicate call:

https://github.com/mozilla/mozmill/blob/master/jsbridge/jsbridge/network.py#L26
https://github.com/mozilla/mozmill/blob/master/jsbridge/jsbridge/network.py#L102

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Please see the wiki page in the URL field in how to setup Mozmill and get started. All is described there.

Comment 6

[Subhendu Ghosh]

Hi, Sorry for replying so late. Whimboo, i will get in touch in irc soon. thankyou.

Comment 7

[Subhendu Ghosh]

Hi, i have completed the setup instructions successfully. But i dont know how to run it. Can anyone help me please?

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+1]]

To run all of our Mutt tests you will have to call the `mutt` cli tool. It expects the Firefox binary via the -b option. You want to run all the existing tests, and ensure that nothing additional is broken. Keep in mind that as one of the first steps `setup_development.py` has to be executed, as best inside a virtual environment to not pollute your system globally with those packages.

Comment 9

[Subhendu Ghosh]

the lines 102 and 103 doesn't seem to affect the execution. Though 'testall' command fails for both (with and without lines 102 and 103).  'testjs' shows following in both cases:


Running JS Tests

(process:16952): GLib-CRITICAL **: g_slice_set_config: assertion 'sys_page_size == 0' failed

(firefox:16952): GLib-GObject-WARNING **: Attempt to add property GnomeProgram::sm-connect after class was initialised

(firefox:16952): GLib-GObject-WARNING **: Attempt to add property GnomeProgram::show-crash-dialog after class was initialised

(firefox:16952): GLib-GObject-WARNING **: Attempt to add property GnomeProgram::display after class was initialised

(firefox:16952): GLib-GObject-WARNING **: Attempt to add property GnomeProgram::default-icon after class was initialised
Gtk-Message: (for origin information, set GTK_DEBUG): failed to retrieve property `GtkRange::activate-slider' of type `gboolean' from rc file value "((GString*) 0x7fd319912780)" of type `GString'
All tests were successful.  Ship it!

Comment 10

[Henrik Skupin [:whimboo][⌚️UTC+1]]

(In reply to Subhendu Ghosh from comment #9)
> the lines 102 and 103 doesn't seem to affect the execution. Though 'testall'
> command fails for both (with and without lines 102 and 103).  'testjs' shows
> following in both cases:

Can you please tell me what is failing? I don't see it from the output of your last comment. That only shows GTK errors which are not directly related to our tests, and which you will also see when starting Firefox from the console.

Comment 11

[Subhendu Ghosh]

Attachment: output of 'testall' command without removing the lines 102 and 103

Comment 12

[Subhendu Ghosh]

Attachment: output of 'testall' command after removing the lines 102 and 103

Comment 13

[Subhendu Ghosh]

Hi whimboo, are the outputs in above attachment okay? if so then line 103 (connecting to js bridge 2nd time ) can be removed.

Comment 14

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Comment on attachment 8444811 [details]
output of 'testall' command without removing the lines 102 and 103

Thank you for the output. I will have a look at. Just for information... please only set the review flag for patches you want to get reviewed but not for simple output. Also I'm watching all my bugs, so a comment would be enough and I will address it.

So what concerns me here is the amount of jsbridge disconnect failures. How often do you get those failures? I see it in the output for the patch being applied and not. So this is very strange.

Comment 15

[Subhendu Ghosh]

i get this output everytime i run the test as 

mutt testall -b /usr/bin/firefox

hope i was doing it right.

Comment 16

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Hm, which version of Firefox is that? 29.0 or 30.0? Would you mind running the tests with a build made by us? You can download the latest nightly build for your platform from http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/latest-mozilla-central/.

Comment 17

[Subhendu Ghosh]

It is firefox 30.0. I am a bit confused which file to download from the above mentioned link. I am using fedora 20.

Comment 18

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Primarily you want to look out for any build which contains Linux. But it depends on if you have a 32bit or 64bit system.

32bit: http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/latest-mozilla-central/firefox-33.0a1.en-US.linux-i686.tar.bz2
64bit: http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/latest-mozilla-central/firefox-33.0a1.en-US.linux-x86_64.tar.bz2

Comment 19

[Subhendu Ghosh]

Attachment: output for nightly_with_l103 'testall ' command

Much better results than the previous

Comment 20

[Subhendu Ghosh]

Attachment: nightly_without_l103_testall

On removing the duplicate line l103 the output is not affected

Comment 21

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Hm, I'm a bit worried about all those test failures you are seeing. Btw, do you leave your box alone while the tests are running? I ask because you should not move the focus from the current window.

Comment 22

[Subhendu Ghosh]

Attachment: Fresh test results

Since you insisted, Fresh results of testall without removing focus from the process.

Comment 23

[Subhendu Ghosh]

Attachment: after updating git repo, new test results

Hi :whimboo i found that the code in github has been updated in the meanwhile so i updated and re-run the tests. The tests still fail badly.

Comment 24

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Subhendu, I would propose that we continue offline from this bug to figure out your problem. I don't want to spam this bug with those partly off-topic discussions. I hope that's fine for you. I will send you an email with the next steps to do tomorrow.

Comment 25

[Subhendu Ghosh]

Hi Henrik,
sure we can do that. Will be waiting for your mail.

Comment 26

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Subhendu, I have sent you an email around 2 weeks ago. Maybe you missed it? But I think that I know what happens in your case. I think it is the same as for bug 1065914. If my assumption is wrong, please lets continue via email or IRC. Thanks.

Comment 27

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Mozmill will reach its end of life soon. We are currently working on getting
all the tests for Firefox ported to Marionette. For status updates please see
bug 1080766.