SQLite storage statements should assert that they're only ever used on one thread

RESOLVED INACTIVE

Status

()

RESOLVED INACTIVE
8 years ago
4 months ago

People

(Reporter: justin.lebar+bug, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Updated

5 years ago
blocking-b2g: --- → koi?
Mass-modify - removal of no longer relevant blocking flags.

Updated

4 years ago
blocking-b2g: koi? → ---
It's not super-clear from the original bug what the dream was here.  It seems like a reasonable behaviour would be if this was the equivalent of the mozStorageStatementScoper noticing that a statement was concurrently being used on multiple threads.  Since buggy code might not use mozStorageStatementScoper and the statement object would need to provide help anyways, the easiest debug algorithm would be to:
- Have all statement methods check if mUsedOnThread is null.  If null, assign the current thread.  If non-null, assert it's the same thread as our thread.
- Have Reset() clear mUsedOnThread.

Any complaint from this would be valid/useful feedback I think, even if it's just failure to Reset() the statement in a timely fashion.

Comment 3

4 months ago
Per policy at https://wiki.mozilla.org/Bug_Triage/Projects/Bug_Handling/Bug_Husbandry#Inactive_Bugs. If this bug is not an enhancement request or a bug not present in a supported release of Firefox, then it may be reopened.
Status: NEW → RESOLVED
Last Resolved: 4 months ago
Resolution: --- → INACTIVE
You need to log in before you can comment on or make changes to this bug.