Closed
Bug 656707
Opened 13 years ago
Closed 11 years ago
Mozmill.get_app_info should not take self.bridge as an argument
Categories
(Testing Graveyard :: Mozmill, defect)
Testing Graveyard
Mozmill
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: k0scist, Assigned: berkerpeksag)
Details
(Whiteboard: [mentor=whimboo][lang=py][good first bug])
Attachments
(1 file)
1.02 KB,
patch
|
whimboo
:
review+
|
Details | Diff | Splinter Review |
https://github.com/mozautomation/mozmill/blob/master/mozmill/mozmill/__init__.py#L281 https://github.com/mozautomation/mozmill/blob/master/mozmill/mozmill/__init__.py#L376 The bridge used will always be self.bridge. It shouldn't be passed, just referenced internally to the function
Comment 1•12 years ago
|
||
Updated locations are here: https://github.com/mozilla/mozmill/blob/master/mozmill/mozmill/__init__.py#L317 https://github.com/mozilla/mozmill/blob/master/mozmill/mozmill/__init__.py#L421
Whiteboard: [mentor=whimboo][lang=py][good first bug]
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → berker.peksag
Assignee | ||
Comment 2•11 years ago
|
||
Attachment #705310 -
Flags: review?(hskupin)
Comment 3•11 years ago
|
||
Comment on attachment 705310 [details] [diff] [review] A simple patch for the bug. Review of attachment 705310 [details] [diff] [review]: ----------------------------------------------------------------- Looks good Berker! I will get it merged in a bit.
Attachment #705310 -
Flags: review?(hskupin) → review+
Comment 4•11 years ago
|
||
https://github.com/mozilla/mozmill/commit/dbb639ba6e98aa443f69c53f24e043d2cea61bf1 If you want to help out with something more challenging please let me know. We most likely can find something for you. Thanks again!
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 5•11 years ago
|
||
(In reply to Henrik Skupin (:whimboo) from comment #4) > If you want to help out with something more challenging please let me know. > We most likely can find something for you. Thanks again! I have found bug 656632 (trivial) and bug 739414, but I'm open to suggestions :)
Updated•8 years ago
|
Product: Testing → Testing Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•