Mozmill.get_app_info should not take self.bridge as an argument

RESOLVED FIXED

Status

Testing Graveyard
Mozmill
RESOLVED FIXED
7 years ago
2 years ago

People

(Reporter: Jeff Hammel, Assigned: berkerpeksag)

Tracking

Details

(Whiteboard: [mentor=whimboo][lang=py][good first bug])

Attachments

(1 attachment)

(Reporter)

Description

7 years ago
https://github.com/mozautomation/mozmill/blob/master/mozmill/mozmill/__init__.py#L281

https://github.com/mozautomation/mozmill/blob/master/mozmill/mozmill/__init__.py#L376

The bridge used will always be self.bridge.  It shouldn't be passed,
just referenced internally to the function
(Assignee)

Updated

6 years ago
Assignee: nobody → berker.peksag
(Assignee)

Comment 2

5 years ago
Created attachment 705310 [details] [diff] [review]
A simple patch for the bug.
Attachment #705310 - Flags: review?(hskupin)
Comment on attachment 705310 [details] [diff] [review]
A simple patch for the bug.

Review of attachment 705310 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good Berker! I will get it merged in a bit.
Attachment #705310 - Flags: review?(hskupin) → review+
https://github.com/mozilla/mozmill/commit/dbb639ba6e98aa443f69c53f24e043d2cea61bf1

If you want to help out with something more challenging please let me know. We most likely can find something for you. Thanks again!
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
(Assignee)

Comment 5

5 years ago
(In reply to Henrik Skupin (:whimboo) from comment #4)
> If you want to help out with something more challenging please let me know.
> We most likely can find something for you. Thanks again!

I have found bug 656632 (trivial) and bug 739414, but I'm open to suggestions :)
Product: Testing → Testing Graveyard
You need to log in before you can comment on or make changes to this bug.