656754 - URLs without the trailing slash "/" result in an Internal Server Error / HTTP status code 500 - AttributeError 'str' object has no attribute 'resolve'

Status: VERIFIED FIXED

(Websites :: webifyme.org, defect, P2)

Description

[William Reynolds [:williamr]]

We just started seeing 500 errors on several Webify Me pages on dev-stage.

This includes:

https://webifyme-dev.allizom.org/quiz/
https://webifyme-dev.allizom.org/features/
https://webifyme-dev.allizom.org/collage/e2c5ffc9c060/

This bug currently blocks QA testing

Comment 1

[Stephen Donner [:stephend] Not actively reading bugmail]

This bug needs an owner - who can take this?

Comment 2

[Austin King [:ozten]]

Pegging celery at af18771ea26faf7a2005 in Vendor library

Comment 3

[Austin King [:ozten]]

/ and /collage/e2c5ffc9c060 - fixed, 500 from Bug#657040 (fixed, but needs restart)

/quiz - 500 'str' object has no attribute 'resolve'

Comment 5

[Austin King [:ozten]]

Okay, we still need to fix /quiz and /collage/e2c5ffc9c060

AttributeError at /quiz

'str' object has no attribute 'resolve'

Comment 6

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to comment #5)
> Okay, we still need to fix /quiz and /collage/e2c5ffc9c060
> 
> AttributeError at /quiz
> 
> 'str' object has no attribute 'resolve'

Where are you seeing these errors?  I'm able to load those two URLs (and more) without triggering a 500, at least ostensibly.

Comment 7

[Austin King [:ozten]]

https://webifyme-dev.allizom.org/quiz

Comment 8

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to comment #7)
> https://webifyme-dev.allizom.org/quiz

Aha; I was using the URLs from comment 0, which all have the trailing slash :-)

Comment 9

[Austin King [:ozten]]

Looks like /quiz isn't a valid link, so this is a lower priority bug to fix.

Comment 10

[Stephen Donner [:stephend] Not actively reading bugmail]

Marking this as blocking bug 655130, because 404s are now returning 500.

Comment 11

[Adam Miller]

If I make the trailing slashes conditional, would that fix this bug?

Comment 12

[Austin King [:ozten]]

(In reply to comment #11)
Not sure what that means.

Normal pages and error pages should be able to render. If 'URLs without a trailing slash' can only be created artificially, then this sounds fine and fixing it completely would be a lower priority.

Why?
Ideally our systems are robust and don't provide known ways to generate server errors for performance and security reasons.

Comment 13

[Adam Miller]

This is what I meant: 

https://github.com/mozilla/webifyme/commit/0f3f5529f3c806f8af6539ad2887d50eb7f65916

Does that resolve this issue?

Comment 14

[Austin King [:ozten]]

Thanks Adam.

Comment 15

[krupa raj[:krupa]]

this is fixed.