Closed Bug 656779 Opened 8 years ago Closed 8 years ago

[RTL] Firstrun discovery animation is wrong in RTL

Categories

(Firefox for Android Graveyard :: General, defect)

defect
Not set

Tracking

(Not tracked)

VERIFIED FIXED
Firefox 6

People

(Reporter: mbrubeck, Assigned: mbrubeck)

References

Details

(Keywords: mobile, regression, rtl)

Attachments

(2 files)

Attached patch patchSplinter Review
The firstrun animation moves the sidebars by the wrong amount when using an RTL locale.  This is a regression from bug 655361.
Attachment #532043 - Flags: review?(wjohnston)
Attachment #532043 - Flags: review?(wjohnston) → review+
Thanks for the quick fix. I didn't manage to get back last night to tell you the result of my testing, but you get it right anyway ;-)

Just a small question: is the main content (logo + "Welcome to fennec") supposed to stay immobile when the sidebars play the animation?
(In reply to comment #1)

> Just a small question: is the main content (logo + "Welcome to fennec")
> supposed to stay immobile when the sidebars play the animation?

No. It's supposed to move with the sidebars
http://hg.mozilla.org/mozilla-central/rev/04338898b5ed
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 6
Verified.  

Mozilla/5.0 (Android; Linux armv71; rv6.0a1) Gecko/20110513 Firefox/6.0a1 Fennec/6.0a1
Device: Droid 2 
OS: Android 2.2

Note: This fix does not consider multiple tabs and then going to about:firstrun.  bug 653141 is a pref to put around the animation so that it only happens on a real first run.  This would make it so that you could not hit a multiple tab situation on a first run.
Status: RESOLVED → VERIFIED
I forgot to copy-paste this into the Gingerbread theme CSS.  (We really need to move common code into a separate source file so we don't have to do this...)

Fortunately I don't think this will affect any users of Firefox 6 or 7, so I am not requesting branch approvals.

Around 2-3% of all Fennec users are in countries where RTL languages are prevalent, and around 25-50% of all Fennec users are using Android 2.3.  I don't know for sure how many are using Fennec with RTL localization; our metrics show the locale as "unknown" for 90% of Fennec users, and zero of the remaining users have RTL locales.  We don't seem to ship any RTL localizations with Fennec, so I think users would need to download a language pack to use one.  By the time they download the language pack they will have seen the firstrun animation already, so they still won't be affected by this bug.

But if there's a chance we will add any RTL locales to Firefox 7 before it ships, then we should request approval to land on Aurora or Beta as needed.
Attachment #550872 - Flags: review?(wjohnston)
Attachment #550872 - Flags: review?(wjohnston) → review+
Pushed gingerbread followup to inbound; this part will land for Firefox 8 only:
http://hg.mozilla.org/integration/mozilla-inbound/rev/57d464afd5e7
You need to log in before you can comment on or make changes to this bug.