656876 - Panning is broken if sidebars are collapsed

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Extension Compatibility, defect)

Description

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch

Someone on IRC (PatrickBic) ask how to hide the sidebars/urlbar for an extension.

By adding those lines to a .css file loaded by an overlay this works:

#toolbar-container, #tabs-container, #controls-sidebar {
  visibility: collapse;
}

but doing this broke panning because Browser.computeSidebarVisibility() returns NaN for the visibility of the sidebars.

The patch just check that and return 0 instead.

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 532167 [details] [diff] [review]
Patch

Matt will need this for the Honeycomb changes too

Comment 2

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

http://hg.mozilla.org/mozilla-central/rev/8d126484c20b

Comment 3

[Anna (Waverley)]

Vivien, can provide some steps to reproduce, please?

Comment 4

[Matt Brubeck (:mbrubeck)]

Verified that this fixes panning with the work-in-progress patch from bug 656329.