Closed
Bug 656876
Opened 15 years ago
Closed 15 years ago
Panning is broken if sidebars are collapsed
Categories
(Firefox for Android Graveyard :: Extension Compatibility, defect)
Firefox for Android Graveyard
Extension Compatibility
Tracking
(Not tracked)
VERIFIED
FIXED
Firefox 6
People
(Reporter: vingtetun, Assigned: vingtetun)
Details
Attachments
(1 file)
|
573 bytes,
patch
|
mfinkle
:
review+
|
Details | Diff | Splinter Review |
Someone on IRC (PatrickBic) ask how to hide the sidebars/urlbar for an extension.
By adding those lines to a .css file loaded by an overlay this works:
#toolbar-container, #tabs-container, #controls-sidebar {
visibility: collapse;
}
but doing this broke panning because Browser.computeSidebarVisibility() returns NaN for the visibility of the sidebars.
The patch just check that and return 0 instead.
Attachment #532167 -
Flags: review?(mark.finkle)
|
||
Updated•15 years ago
|
OS: Linux → All
Hardware: x86_64 → All
|
||
Comment 1•15 years ago
|
||
Comment on attachment 532167 [details] [diff] [review]
Patch
Matt will need this for the Honeycomb changes too
Attachment #532167 -
Flags: review?(mark.finkle) → review+
|
Assignee | |
Comment 2•15 years ago
|
||
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Updated•15 years ago
|
Assignee: nobody → 21
|
||
Comment 3•15 years ago
|
||
Vivien, can provide some steps to reproduce, please?
|
|
||
Comment 4•15 years ago
|
||
Verified that this fixes panning with the work-in-progress patch from bug 656329.
Status: RESOLVED → VERIFIED
|
|
||
Updated•15 years ago
|
Target Milestone: --- → Firefox 5
|
|
||
Updated•15 years ago
|
Target Milestone: Firefox 5 → Firefox 6
You need to log in
before you can comment on or make changes to this bug.
Description
•