Make exhibit slider facet work with standards mode

VERIFIED FIXED in 1.2

Status

VERIFIED FIXED
8 years ago
8 years ago

People

(Reporter: Pike, Assigned: Pike)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

8 years ago
There's a fix in upstream exhibit to make the slider facet work in standards mode.

We should downstream that, just a cherry pick. Needs to land in slider.js and all bundles.
(Assignee)

Comment 2

8 years ago
Created attachment 532248 [details] [diff] [review]
update slider.js and bundles

updating the slider and bundles.

The differences in quoting are intentional, as that's what the code does in exhibit, apparenlty.

Got r=stas on irc.
Attachment #532248 - Flags: review+
(Assignee)

Comment 3

8 years ago
https://github.com/mozilla/elmo/commit/3c1a55f872aaeb89a358e259d31bf923c76b4f0d, FIXED.
Assignee: nobody → l10n
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.2
How do I test this in "standards mode?" -- thanks!
(Assignee)

Comment 5

8 years ago
If it works, it's VERIFIED.

The culprit was that the page went from quirks mode to strict mode with a template change, and regressed the existing behaviour.

Works on https://l10n-stage-sj.mozilla.org/shipping/dashboard?locale=pl (it's the slider for missing strings which you can shuffle around), which works and shows the histogram, so marking VERIFIED.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.