656928 - Make exhibit slider facet work with standards mode

Status: VERIFIED FIXED

(Webtools Graveyard :: Elmo, defect)

Description

[Axel Hecht [:Pike]]

There's a fix in upstream exhibit to make the slider facet work in standards mode.

We should downstream that, just a cherry pick. Needs to land in slider.js and all bundles.

Comment 1

[Axel Hecht [:Pike]]

Upstream ticket is http://code.google.com/p/simile-widgets/issues/detail?id=283 (which I filed, go figure), fix is http://code.google.com/p/simile-widgets/source/diff?spec=svn2088&r=2088&format=side&path=/exhibit/trunk/src/webapp/api/scripts/ui/facets/slider.js

Comment 2

[Axel Hecht [:Pike]]

Attachment: update slider.js and bundles

updating the slider and bundles.

The differences in quoting are intentional, as that's what the code does in exhibit, apparenlty.

Got r=stas on irc.

Comment 3

[Axel Hecht [:Pike]]

https://github.com/mozilla/elmo/commit/3c1a55f872aaeb89a358e259d31bf923c76b4f0d, FIXED.

Comment 4

[Stephen Donner [:stephend] Not actively reading bugmail]

How do I test this in "standards mode?" -- thanks!

Comment 5

[Axel Hecht [:Pike]]

If it works, it's VERIFIED.

The culprit was that the page went from quirks mode to strict mode with a template change, and regressed the existing behaviour.

Works on https://l10n-stage-sj.mozilla.org/shipping/dashboard?locale=pl (it's the slider for missing strings which you can shuffle around), which works and shows the histogram, so marking VERIFIED.