656933 - Bump max version after validation without sending emails

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Administration, defect, P1)

Description

[Kumar McMillan [:kumar]]

After bulk addon validation, an admin can upgrade all passing addons (bug 655376).  However, we can't test this on PAMO since it will send real emails.  We need a checkbox or something to disable the email feature yet still upgrade all addons.

Comment 1

[Justin Scott [:fligtar]]

It'd be awesome if we found a preview-emailing solution that worked for all cases. We have this problem with editor tools on preview too. Maybe something like a flag that turns all emails into a specific log file or emails the logged-in user who triggered it.

Comment 2

[Justin Scott [:fligtar]]

More specifically, my concern is that there's much greater risk here to email thousands of people accidentally because a box wasn't checked while testing or the page was refreshed and the box was unchecked or something like that.

I'd rather make it opt-in than opt-out if we can't do something implicit for all of preview.

Comment 3

[krupa raj[:krupa]]

Is this fix landing today?

Comment 4

[Wil Clouser [:clouserw]]

(In reply to comment #1)
> It'd be awesome if we found a preview-emailing solution that worked for all
> cases. We have this problem with editor tools on preview too. Maybe
> something like a flag that turns all emails into a specific log file or
> emails the logged-in user who triggered it.

Things that send email aren't always associated with a user (eg. tasks or cron jobs).  

We could send all mail to a mailing list, but that would prevent anyone from resetting their password or registering for a new account.  In the past we've always used switches for this stuff and have survived.  /me is happy to hear less fragile solutions though.

Comment 5

[krupa raj[:krupa]]

This is blocking QA and needs to go live this week. Moving the severity to blocker.

Comment 6

[Kumar McMillan [:kumar]]

Email-previewing implemented in https://github.com/jbalogh/zamboni/commit/fae9a75e9c634588532bc48ea07002727daaf9e8

When in either bulk notify dialogs you see a checkbox for "log emails instead of sending" and it's checked by default.  After processing, you'll then get a link to download a CSV log of emails that were sent.

On the backend this was done in a generic way so that other views can hook up to this when needed but no effort was made to actually hook it up to other parts of the site.