Closed Bug 656936 Opened 10 years ago Closed 3 years ago

Remove GetRemoveFolderTransaction

Categories

(Toolkit :: Places, defect, P2)

Product:
Toolkit
Component:
Places
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla60
Tracking Flags:
Tracking Status
firefox60 --- fixed

People

(Reporter: mak, Assigned: mak)

References

(Blocks 1 open bug)

Details

(Whiteboard: [fxsearch])

Attachments

(1 file)

Bug 656936 - Remove Bookmarks::GetRemoveFolderTransaction.
59 bytes, text/x-review-board-request
standard8
: review+
Details 
This method was introduced because parent ids change when doing/undoing Places transactions, we could instead use guids in the transaction and avoid to reuse ids.
Depends on: PlacesAsyncTransact
Priority: -- → P3
Depends on: 1131491
No longer depends on: PlacesAsyncTransact
This is still used in a few tests that should be rewritten
https://searchfox.org/mozilla-central/search?q=getRemoveFolderTransaction&case=false&regexp=false&path=
Blocks: 1083465
Priority: P3 → P2
Whiteboard: [fx-search]
Summary: Kill GetRemoveFolderTransaction method, use guids instead → Remove GetRemoveFolderTransaction
Whiteboard: [fx-search] → [fxsearch]
Assignee: nobody → mak77
Status: NEW → ASSIGNED
Comment on attachment 8953545 [details]
Bug 656936 - Remove Bookmarks::GetRemoveFolderTransaction.

https://reviewboard.mozilla.org/r/222762/#review228746
Attachment #8953545 - Flags: review?(standard8) → review+
Pushed by mak77@bonardo.net:
https://hg.mozilla.org/integration/autoland/rev/96d20e4d0a56
Remove Bookmarks::GetRemoveFolderTransaction. r=standard8
https://hg.mozilla.org/mozilla-central/rev/96d20e4d0a56
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox60: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
You need to log in before you can comment on or make changes to this bug.