657051 - Write the task that gives repackaged add-ons a new home

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Developer Pages, defect, P1)

Description

[Wil Clouser [:clouserw]]

When the builder finishes repackaging an add-on it pings AMO to let it know.  AMO grabs that info and fires off a celery task.  That celery task is this bug.  When it runs, it should look at the data it was given (see bug 656993 for what the builder sends to us) and then:

- Grab the new file
- Create a new version on the AMO side (actually, the POST data from the builder should tell us the new version too!)
- Add the new file to the new version
- Save the new version (at whatever STATUS the old version was at; public, prelim, etc.)
- Email the author that we successfully repackaged their add-on with a new version (if you need text for this, please ask.  At a minimum, get r? on anything you write)
- Have substantial logging and graceful failing in all of this

Comment 1

[Jeff Balogh (:jbalogh)]

I got the bug that kicks off this task (bug 657052), so here's my code: https://github.com/jbalogh/zamboni/commit/b80c6b0.

It's calling files.tasks.repackage_jetpack, but you can rename that however you'd like as long as you update files.views.builder_pingback. I check that the builder sent back an id and a secret and you can add other validation inside the view.

Comment 2

[Jeff Balogh (:jbalogh)]

Don't forget to update files.jetpack_version.

Comment 3

[Jeff Balogh (:jbalogh)]

r? https://github.com/jbalogh/zamboni/compare/jp (when the bulk compat queue is not burning).

Comment 4

[Jeff Balogh (:jbalogh)]

Merge: https://github.com/jbalogh/zamboni/commit/7bb26c6 
Patch: https://github.com/jbalogh/zamboni/commit/7e583f9