657058 - [webby] 500 when a project has a dash in the slug

Status: VERIFIED FIXED

(Webtools Graveyard :: Elmo, defect, P3)

Description

[Staś Małolepszy :stas]

Reverse URL matching fails for webby.views.project when the slug contains a dash.

Comment 1

[Axel Hecht [:Pike]]

FWIW, http://docs.djangoproject.com/en/1.3/ref/models/fields/#slugfield says that dashes aren't valid slugs.

Comment 2

[Peter Bengtsson [:peterbe]]

Attachment: Allows _ and - in the slug URL

[\w-]+ seems the most common way to do a slug URL
http://stackoverflow.com/questions/1700983/slug-field-followed-by-url

Comment 3

[Staś Małolepszy :stas]

Comment on attachment 535025 [details] [diff] [review]
Allows _ and - in the slug URL

Review of attachment 535025 [details] [diff] [review]:
-----------------------------------------------------------------

r=me.  Perfect!  As a nice side-effect, we can use digits in slugs now, too!

Comment 4

[Peter Bengtsson [:peterbe]]

Landed https://github.com/mozilla/elmo/commit/76048b6ebe81df38eb4167a10ddb47ef7b9e39c1

Comment 5

[Stephen Donner [:stephend] Not actively reading bugmail]

How do we verify this on the staging server?  Thanks!

https://l10n-stage-sj.mozilla.org/

Comment 6

[Peter Bengtsson [:peterbe]]

(In reply to comment #5)
> How do we verify this on the staging server?  Thanks!
> 
> https://l10n-stage-sj.mozilla.org/
I guess, on dev, you could log in to the Admin interface and change a slug manually to one that contains a hyphen. I don't have a username+password for you. I guess I can create one for you if you like.

Comment 7

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to comment #6)
> I guess, on dev, you could log in to the Admin interface and change a slug
> manually to one that contains a hyphen. I don't have a username+password for
> you. I guess I can create one for you if you like.

If you would; thanks!  Alternatively, another developer/l10n power-user with Admin privs could also verify the bug.

Comment 8

[Staś Małolepszy :stas]

I created a new webby project with the following slug: firefox-36x-upgrade-survey

The URL is: https://l10n-dev-sj.mozilla.org/webby/firefox-36x-upgrade-survey

Comment 9

[Stephen Donner [:stephend] Not actively reading bugmail]

Thanks, Staś; verified FIXED.