UI should not do data loading

RESOLVED FIXED

Status

Tree Management Graveyard
TBPL
RESOLVED FIXED
7 years ago
3 years ago

People

(Reporter: Swatinem, Assigned: Swatinem)

Tracking

Details

Attachments

(1 attachment)

(Assignee)

Description

7 years ago
Created attachment 532503 [details] [diff] [review]
move loading to Controller and use callbacks

UI should not do data loading on itself, rather be notified via callbacks when data arrives. This moves the tree status updates and calendar updates to Controller instead.
Attachment #532503 - Flags: review?(mstange)
Comment on attachment 532503 [details] [diff] [review]
move loading to Controller and use callbacks

Review of attachment 532503 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/UserInterface.js
@@ +113,5 @@
>        },
>        handleInitialPushlogLoad: function () {
>          $("#pushes").removeClass("initialload");
>        },
> +      treeStatus: function (data, calendarFallback) {

Call this "updateTreeStatus".
Attachment #532503 - Flags: review?(mstange) → review+
(Assignee)

Comment 2

7 years ago
http://hg.mozilla.org/users/mstange_themasta.com/tinderboxpushlog/rev/01fd81105584
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Depends on: 660184
Product: Webtools → Tree Management
Product: Tree Management → Tree Management Graveyard
You need to log in before you can comment on or make changes to this bug.