657203 - UI should not do data loading

Status: RESOLVED FIXED

(Tree Management Graveyard :: TBPL, defect)

Description

[Arpad Borsos [:Swatinem]]

Attachment: move loading to Controller and use callbacks

UI should not do data loading on itself, rather be notified via callbacks when data arrives. This moves the tree status updates and calendar updates to Controller instead.

Comment 1

[Markus Stange [:mstange]]

Comment on attachment 532503 [details] [diff] [review]
move loading to Controller and use callbacks

Review of attachment 532503 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/UserInterface.js
@@ +113,5 @@
>        },
>        handleInitialPushlogLoad: function () {
>          $("#pushes").removeClass("initialload");
>        },
> +      treeStatus: function (data, calendarFallback) {

Call this "updateTreeStatus".

Comment 2

[Arpad Borsos [:Swatinem]]

http://hg.mozilla.org/users/mstange_themasta.com/tinderboxpushlog/rev/01fd81105584