657303 - ESC should close the Scratchpad window

Status: RESOLVED WONTFIX

(DevTools :: General, defect)

Description

[Dão Gottwald [:dao]]

I managed to accidentally open the Scratchpad twice in the last few days (e.g. by hitting F4 instead of F5) but wasn't able to close it just as easily. Both F4 and ESC should probably close the Scratchpad window.

Comment 1

[Gabriel Koritzky]

You can close it by pressing Alt+F4 in windows, but I agree that closing Scratchpad with the ESC key sounds like a rather obvious shortcut.

Comment 2

[Teddy Ni]

Attachment: Scratchpad close on F4 and ESC

Comment 3

[Teddy Ni]

Actually, I'm unsure whether F4 should close Scratchpad, since we do allow multiple Scratchpads. Also, spamming F4 does not close but opens many copies.

Comment 4

[Dão Gottwald [:dao]]

F4 can continue to operate as currently in the browser window, i.e. spawn a Scratchpad window regardless of how many exist already. In a Scratchpad window, it does nothing right now.

Comment 5

[Teddy Ni]

Yes, that's right. Do you think F4 should close the Scratchpad after it opens, then? If so, the problem with the current patch is that sometimes, when holding down the F4 key continuously, I find that when I stop multiple Scratchpads have opened. Some more work would have to be done in that case, to prevent that happening. I'd be happy to work on it, if someone could give me a pointer in the right direction concerning how to tackle such a timing issue. Or if we decide that F4 should not close the Scratchpad, just ESC, then that is easy.

Comment 6

[Dão Gottwald [:dao]]

(In reply to comment #5)
> Yes, that's right. Do you think F4 should close the Scratchpad after it
> opens, then?

I would welcome this since it would be the most convenient way to get rid of the window when you accidentally opened it with F4.

> If so, the problem with the current patch is that sometimes,
> when holding down the F4 key continuously, I find that when I stop multiple
> Scratchpads have opened.

This doesn't sound like it's worth worrying about. It's unclear why a user would want to hold F4.

Comment 7

[Rob Campbell [:rc] (:robcee)]

I think this will be less of a problem when we have a fix for bug 663746 which I've nominated for tracking-fx-6.

Any recommendations for an alternate keyboard shortcut to open the scratchpad? If so, please leave them in that bug. Thanks!

Comment 8

[Rob Campbell [:rc] (:robcee)]

now that bug 663746 has landed, is this bug still important? You should be able to close the Scratchpad using Ctrl-W or Alt-F4 as you would any other window. I'd like to mark this WONTFIX.

Comment 9

[Dão Gottwald [:dao]]

ESC should probably close it still.

Comment 10

[Rob Campbell [:rc] (:robcee)]

closing. Been open too long.