Closed Bug 657303 Opened 13 years ago Closed 13 years ago

ESC should close the Scratchpad window

Categories

(DevTools :: General, defect)

6 Branch
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED WONTFIX
Firefox 7

People

(Reporter: dao, Unassigned)

References

Details

(Whiteboard: [scratchpad])

Attachments

(1 file)

I managed to accidentally open the Scratchpad twice in the last few days (e.g. by hitting F4 instead of F5) but wasn't able to close it just as easily. Both F4 and ESC should probably close the Scratchpad window.
You can close it by pressing Alt+F4 in windows, but I agree that closing Scratchpad with the ESC key sounds like a rather obvious shortcut.
Whiteboard: [scratchpad]
Actually, I'm unsure whether F4 should close Scratchpad, since we do allow multiple Scratchpads. Also, spamming F4 does not close but opens many copies.
F4 can continue to operate as currently in the browser window, i.e. spawn a Scratchpad window regardless of how many exist already. In a Scratchpad window, it does nothing right now.
Yes, that's right. Do you think F4 should close the Scratchpad after it opens, then? If so, the problem with the current patch is that sometimes, when holding down the F4 key continuously, I find that when I stop multiple Scratchpads have opened. Some more work would have to be done in that case, to prevent that happening. I'd be happy to work on it, if someone could give me a pointer in the right direction concerning how to tackle such a timing issue. Or if we decide that F4 should not close the Scratchpad, just ESC, then that is easy.
(In reply to comment #5)
> Yes, that's right. Do you think F4 should close the Scratchpad after it
> opens, then?

I would welcome this since it would be the most convenient way to get rid of the window when you accidentally opened it with F4.

> If so, the problem with the current patch is that sometimes,
> when holding down the F4 key continuously, I find that when I stop multiple
> Scratchpads have opened.

This doesn't sound like it's worth worrying about. It's unclear why a user would want to hold F4.
I think this will be less of a problem when we have a fix for bug 663746 which I've nominated for tracking-fx-6.

Any recommendations for an alternate keyboard shortcut to open the scratchpad? If so, please leave them in that bug. Thanks!
now that bug 663746 has landed, is this bug still important? You should be able to close the Scratchpad using Ctrl-W or Alt-F4 as you would any other window. I'd like to mark this WONTFIX.
ESC should probably close it still.
Depends on: 653427
Target Milestone: --- → Firefox 7
Version: Trunk → 6 Branch
Summary: F4 and ESC should close the Scratchpad window → ESC should close the Scratchpad window
closing. Been open too long.
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → WONTFIX
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: