657347 - Display test failure details in endurance results

Status: RESOLVED FIXED

(Mozilla QA Graveyard :: Mozmill Result Dashboard, defect)

Description

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Currently failures are not displayed in the endurance results dashboard, which means they can easily go unnoticed, and are difficult to investigate.

Comment 1

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Attachment: Add standard test results to endurance report. v1

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Comment on attachment 532651 [details] [diff] [review]
Add standard test results to endurance report. v1

>+++ b/_attachments/js/dashboard.js
>         context.render(template).replace('#content').then(function () {
>+          $("#endurance_result").tablesorter();
>+          $("#result").tablesorter();

We don't want to sort the tables by default, because you will not be able to return to the original order of tests. Please remove those two lines.

Comment 3

[Dave Hunt [:davehunt] [he/him] ⌚BST]

(In reply to comment #2)
> Comment on attachment 532651 [details] [diff] [review] [review]
> Add standard test results to endurance report. v1
> 
> >+++ b/_attachments/js/dashboard.js
> >         context.render(template).replace('#content').then(function () {
> >+          $("#endurance_result").tablesorter();
> >+          $("#result").tablesorter();
> 
> We don't want to sort the tables by default, because you will not be able to
> return to the original order of tests. Please remove those two lines.

This doesn't apply a sort, it makes the tables sortable.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Hm, why don't we have those lines for the other pages and sorting works thought? Do I miss something here?

Comment 5

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Yeah so the top level reports are sortable and have default sorts applied, but the individual testrun reports are not sortable. I have raised bug 657651 to fix this for other reports.

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Comment on attachment 532651 [details] [diff] [review]
Add standard test results to endurance report. v1

Ok, looks fine then. Please go ahead and land it on the master branch. You now have write access to the repository.

Comment 7

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Landed as:
https://github.com/whimboo/mozmill-dashboard/commit/3164ca763fe61112873c66a9351e36313ecc0354

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Needs to be pushed to production once we have landed all the other remaining patches.

Comment 9

[Henrik Skupin [:whimboo][⌚️UTC+1]]

All changes have been pushed to production now.