remove unix classic theme

VERIFIED FIXED in mozilla0.8

Status

P2
normal
VERIFIED FIXED
18 years ago
10 years ago

People

(Reporter: hewitt, Assigned: hewitt)

Tracking

Trunk
mozilla0.8
x86
Linux

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

18 years ago
Correct me if I'm wrong, Ben, but there should be no need to keep the unix
classic theme in the tree.  It hasn't been touched since I've been around
Netscape, and I see no reason to keep it around.
(Assignee)

Updated

18 years ago
Status: NEW → ASSIGNED
Priority: -- → P2
FWIW, some of the files are loaded when I run -- I see CSS errors in them.  See
bug 65443.
(Assignee)

Comment 2

18 years ago
The Makefile.in files in classic point to the unix folders.  I was not aware 
that these files were included in the classic.jar file on unix, so I fear that 
just removing them may break stuff.  I'll have to remove them all and then go 
through each one and make sure the windows equivalent works well.

Comment 3

18 years ago
Themes Triage Team nsbeta1+
Keywords: nsbeta1
(Assignee)

Updated

18 years ago
Target Milestone: --- → mozilla0.8

Comment 4

18 years ago
Let me make sure I'm correct...what you call the "Unix classic theme", is
actually the XFE theme before we switched to XPFE, right?
No, I think it was originally a branch off the Windows classic skin that nobody
wanted to maintain, so it's still pretty similar to the Windows classic skin.
(Assignee)

Comment 6

18 years ago
Created attachment 23763 [details] [diff] [review]
patch to fix
(Assignee)

Updated

18 years ago
Keywords: review

Comment 7

18 years ago
What about all the Unix-specific files?
(Assignee)

Comment 8

18 years ago
The Unix-specific files are all in the unix directories that I listed in the
patch.  They will all be removed.  They are not currently performing any
function on the unix builds of the classic skin.

Comment 9

18 years ago
Oops sorry, I missed:

"REMOVE ALL FILES UNDER =============
themes/classic/navigator/unix
themes/classic/global/unix
themes/classic/communicator/unix
themes/classic/communicator/sidebar/unix"

r=blake assuming you've built and tested this on linux.

Comment 10

18 years ago
r=timeless whack em
Keywords: review → approval
OS: All → Linux
Hardware: All → PC

Comment 11

18 years ago
a=hangas
(Assignee)

Comment 12

18 years ago
fixed
Status: ASSIGNED → RESOLVED
Last Resolved: 18 years ago
Keywords: approval
Resolution: --- → FIXED

Comment 13

18 years ago
Marking verified (2001-02-13-09-Mtrunk)
Status: RESOLVED → VERIFIED
Product: Core → SeaMonkey
You need to log in before you can comment on or make changes to this bug.