657458 - Expose js::Foreground::free outside of js

Status: NEW

(Core :: JavaScript Engine, defect)

Description

[Justin Lebar (not reading bugmail)]

We really want to call js::Foreground::free in bug 656911, but end up calling JS_free instead, because that's the best we've got.

Comment 1

[David Mandelin [:dmandelin]]

Should JS_free even be calling the background free thing anyway? It seems that JSAPI users probably aren't calling JS_free so many times that we need to do it on a background thread, and something simpler and more direct would be easier for them to use.

Comment 2

[Justin Lebar (not reading bugmail)]

As John noticed, I typoed the bug number in comment 0.  It should be 656991.

Comment 3

[David Mandelin [:dmandelin]]

Do you still need this? It's been a week or two. But we should fix it if it helps you.

Comment 4

[Justin Lebar (not reading bugmail)]

I don't appreciate the differences between JS_free and js::Foreground::free.  I have code calling the former which apparently should be calling the latter.  It's not many or particularly large allocations.

Maybe you can tell me: Do I need this fix?

(JSAutoStructuredCloneBuffer, used by indexdb has the same problem.)