657525 - Site-specific preferences for chromeless app tabs

Status: RESOLVED WONTFIX

(Firefox :: Tabbed Browser, defect)

Description

[:Felipe Gomes (needinfo for replies!)]

Attachment: Patch

Moving the site-specific patch from bug 644721 over here. Updated to tip and to go along with the latest patch there.


This adds a menu entry in app tabs that says "Show toolbars for this site" and disables the chromeless app tabs features for that domain

Comment 1

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 532806 [details] [diff] [review]
Patch

It would be better to use an actual boolean as the pref value rather than "true"/"".

"Show toolbars for this site" is a bit odd. Seems like "for this pinned tab" (or "app tab" or whatever) would be perhaps clearer, since the setting only applies to that site as an app tab, rather than to that site globally (i.e. when loaded in a normal tab). Maybe that's a distinction not worth making, though.

This looks fine, but will need some rebasing on top of a new patch for bug 644721, I think.

Comment 2

[Siddhartha Dugar [:sdrocking]]

This menu item should not appear when "browser.tabs.chromelessAppTabs" is false.

Comment 3

[Dão Gottwald [:dao]]

wontfix as per bug 769101 comment 16