Closed Bug 657528 Opened 8 years ago Closed 8 years ago

Use a volatile pointer to force a trap.

Categories

(Core :: XPCOM, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla6

People

(Reporter: espindola, Assigned: espindola)

Details

Attachments

(1 file, 1 obsolete file)

Clang issues the warning:
    
mozalloc_abort.cpp:64:22: warning: indirection of non-volatile null pointer will be deleted, not trap [-Wnull-dereference]
    
And sure enough, TouchBadMemory is currently broken with clang. That breaks mozalloc_abort which breaks NS_DebugBreak which breaks the crashreport test.
Attachment #532808 - Flags: review?(ehsan)
Comment on attachment 532808 [details] [diff] [review]
Use a volatile pointer to force a trap.

r=me.

Nit: can you please fix the comment indentation?  Thanks!
Attachment #532808 - Flags: review?(ehsan) → review+
Attached patch Updated patch.Splinter Review
Attachment #532808 - Attachment is obsolete: true
Attachment #532812 - Flags: review?(ehsan)
Attachment #532812 - Flags: review?(ehsan) → review?
http://hg.mozilla.org/projects/cedar/rev/7839f528cda0
Assignee: nobody → respindola
Status: NEW → RESOLVED
Closed: 8 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Man, I'm too used to landing stuff on m-c now!
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Whiteboard: fixed-in-cedar
Pushed:
http://hg.mozilla.org/mozilla-central/rev/7839f528cda0
Status: REOPENED → RESOLVED
Closed: 8 years ago8 years ago
OS: Mac OS X → All
Hardware: x86 → All
Resolution: --- → FIXED
Whiteboard: fixed-in-cedar
Target Milestone: --- → mozilla6
Version: unspecified → Trunk
You need to log in before you can comment on or make changes to this bug.