Closed Bug 657548 Opened 10 years ago Closed 10 years ago

Remove duplicate and unused CIDs from nsContentCID.h and nsLayoutCID.h

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla6

People

(Reporter: craig.topper, Assigned: craig.topper)

Details

Attachments

(2 files)

nsContentCID.h and nsLayoutCID.h have several CIDs duplicated. Fortunately, they have identical values.

While reviewing I also found several unused CIDs so I'm removing those as well. I don't claim it to be a complete review and there could still be others that are unused.
Comment on attachment 532870 [details] [diff] [review]
Remove duplicate and unused CIDs from nsContentCID.h and nsLayoutCID.h

This patch also moves the CID for audio element to ContentCID.h since that's where the other elements live.

All the duplicates were left in the file appropriate to where the implementation lives.
Attachment #532870 - Flags: review?(jst)
Attachment #532875 - Flags: review?(jst)
Attachment #532870 - Flags: review?(jst) → review+
Comment on attachment 532875 [details] [diff] [review]
Part 2: Remove more unused CIDs.

r=jst!
Attachment #532875 - Flags: review?(jst) → review+
Keywords: checkin-needed
Pushed:
http://hg.mozilla.org/mozilla-central/rev/e6c321d64c85
http://hg.mozilla.org/mozilla-central/rev/49eaed73c95d
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-cedar]
Target Milestone: --- → mozilla6
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.