Remove duplicate and unused CIDs from nsContentCID.h and nsLayoutCID.h

RESOLVED FIXED in mozilla6

Status

()

Core
DOM
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Craig Topper, Assigned: Craig Topper)

Tracking

Trunk
mozilla6
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

6 years ago
nsContentCID.h and nsLayoutCID.h have several CIDs duplicated. Fortunately, they have identical values.

While reviewing I also found several unused CIDs so I'm removing those as well. I don't claim it to be a complete review and there could still be others that are unused.
(Assignee)

Comment 1

6 years ago
Created attachment 532870 [details] [diff] [review]
Remove duplicate and unused CIDs from nsContentCID.h and nsLayoutCID.h
(Assignee)

Comment 2

6 years ago
Comment on attachment 532870 [details] [diff] [review]
Remove duplicate and unused CIDs from nsContentCID.h and nsLayoutCID.h

This patch also moves the CID for audio element to ContentCID.h since that's where the other elements live.

All the duplicates were left in the file appropriate to where the implementation lives.
Attachment #532870 - Flags: review?(jst)
(Assignee)

Comment 3

6 years ago
Created attachment 532875 [details] [diff] [review]
Part 2: Remove more unused CIDs.
(Assignee)

Updated

6 years ago
Attachment #532875 - Flags: review?(jst)

Updated

6 years ago
Attachment #532870 - Flags: review?(jst) → review+
Comment on attachment 532875 [details] [diff] [review]
Part 2: Remove more unused CIDs.

r=jst!
Attachment #532875 - Flags: review?(jst) → review+
(Assignee)

Updated

6 years ago
Keywords: checkin-needed
http://hg.mozilla.org/projects/cedar/rev/e6c321d64c85
http://hg.mozilla.org/projects/cedar/rev/49eaed73c95d
Flags: in-testsuite-
Keywords: checkin-needed
Whiteboard: [fixed-in-cedar]
Pushed:
http://hg.mozilla.org/mozilla-central/rev/e6c321d64c85
http://hg.mozilla.org/mozilla-central/rev/49eaed73c95d
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-cedar]
Target Milestone: --- → mozilla6
You need to log in before you can comment on or make changes to this bug.