657613 - [prod] UnboundLocalError: local variable 'invite' referenced before assignment

Status: VERIFIED FIXED

(Websites Graveyard :: markup.mozilla.org, defect)

Description

[Matt Brandt [:mbrandt]]

Steps to reproduce:
1. go to /requests/save_mark
2. draw and submit a mark

Actual:
after submitting a mark a 500 error occurs.

Traceback (most recent call last):

  File "/data/www/python/markup.mozilla.org/markup/ffdemo/vendor/src/django/django/core/handlers/base.py", line 100, in get_response
    response = callback(request, *callback_args, **callback_kwargs)

  File "/data/www/python/markup.mozilla.org/markup/ffdemo/vendor/src/django/django/views/decorators/http.py", line 37, in inner
    return func(request, *args, **kwargs)

  File "/data/www/python/markup.mozilla.org/markup/ffdemo/markup/requests.py", line 123, in save_mark
    new_mark_reference = common.save_new_mark_with_data(mark_data, request.META['REMOTE_ADDR'])

  File "/data/www/python/markup.mozilla.org/markup/ffdemo/../ffdemo/markup/common.py", line 92, in save_new_mark_with_data
    if invite:

UnboundLocalError: local variable 'invite' referenced before assignment

Comment 1

[[:brez]]

Fixed - just need to move the invite var up in scope:

https://github.com/mozilla/markup/commit/e43db3d652ccd1ec8cbab326c922daa2e390efdb

Comment 2

[Matt Brandt [:mbrandt]]

Verified on dev, stage, and prod. I was able to draw and submit marks.