Closed Bug 657617 Opened 9 years ago Closed 9 years ago

update verify scripts don't raise windows binary diffs properly

Categories

(Release Engineering :: General, defect)

x86_64
Linux
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: bhearsum, Assigned: bhearsum)

References

Details

Attachments

(1 file)

The update verify scripts grep for '^Binary files' to identify binary file diffs, but on Windows, grep says "Files source/bin/smime3.dll and target/bin/smime3.dll differ" instead. We should probably be looking for '^Files.*and.*differ$' in addition to the existing pattern.
Comment on attachment 532958 [details] [diff] [review]
fix binary file catching on windows

Looks good.
Attachment #532958 - Flags: review?(rail) → review+
Comment on attachment 532958 [details] [diff] [review]
fix binary file catching on windows

changeset:   1416:7dd2dbc1c1b2
Attachment #532958 - Flags: checked-in+
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.