Closed
Bug 657617
Opened 14 years ago
Closed 14 years ago
update verify scripts don't raise windows binary diffs properly
Categories
(Release Engineering :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: bhearsum, Assigned: bhearsum)
References
Details
Attachments
(1 file)
|
1.17 KB,
patch
|
rail
:
review+
bhearsum
:
checked-in+
|
Details | Diff | Splinter Review |
The update verify scripts grep for '^Binary files' to identify binary file diffs, but on Windows, grep says "Files source/bin/smime3.dll and target/bin/smime3.dll differ" instead. We should probably be looking for '^Files.*and.*differ$' in addition to the existing pattern.
|
Assignee | |
Comment 1•14 years ago
|
||
Attachment #532958 -
Flags: review?(rail)
|
||
Comment 2•14 years ago
|
||
Comment on attachment 532958 [details] [diff] [review]
fix binary file catching on windows
Looks good.
Attachment #532958 -
Flags: review?(rail) → review+
|
|
Assignee | |
Comment 3•14 years ago
|
||
Comment on attachment 532958 [details] [diff] [review]
fix binary file catching on windows
changeset: 1416:7dd2dbc1c1b2
Attachment #532958 -
Flags: checked-in+
|
|
Assignee | |
Updated•14 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
|
||
Updated•12 years ago
|
Product: mozilla.org → Release Engineering
You need to log in
before you can comment on or make changes to this bug.
Description
•