657717 - runtestremote change for --pidfile parameter need to land on mozilla-aurora

Status: RESOLVED FIXED

(Testing :: General, defect)

Description

[Mike Taylor [:bear]]

the changes made in bug 650828 to add a pidfile parameter to the remote test runners needs to land in mozilla-aurora so we can enable android tests there.

Comment 1

[cmtalbert]

Hey Christian and Johnathan,
We'd like to re-enable the Android tegra tests for mozilla-aurora and land the necessary test-infrastructure changes required to do that before the m-c merge to aurora next week.

This gives us a week to shake things out before introducing new variables to the mix -- there have been some fennec-specific issues with changing the process name to org.mozilla.fennec_aurora, the shared ID update etc.  And so it'd be quite valuable to us to make these changes on aurora to ensure our android infrastructure is working well on aurora before the m-c merge.

This is probably 1-2 patches (we've already landed them all on m-c, we're just going to land them on aurora now).  Joel will be attaching them later today or tomorrow.  They will only affect Android fennec test runs.

Can we get your a+ for this?

Thanks.

Comment 2

[Joel Maher ( :jmaher ) (UTC -8)]

Attachment: add --pidfile to the cli which will create a pidfile while the harness is running (1.0)

add pidfile from the cli argument as well as pidfile.xpcshell.pid when we start the webserver.

Comment 3

[cmtalbert]

Comment on attachment 533043 [details] [diff] [review]
add --pidfile to the cli which will create a pidfile while the harness is running (1.0)

This is the change we need in the test harness from m-c.  Thanks for getting this on the bug.  r+

Comment 4

[Johnathan Nightingale [:johnath]]

Do I understand correctly that these are test-only changes? If so, a=me to land them, but being test only doesn't mean they don't need to be carefully watched for bustage. I know you know, I'm just being explicit so that we all understand.

And does this need to land on mozilla-beta now that the aurora->beta merge has happened?

Comment 5

[Mike Taylor [:bear]]

I'm +1 to the changes landing on mozilla-beta sooner than later, the harnass code will need to be tested on beta also.

Comment 6

[Joel Maher ( :jmaher ) (UTC -8)]

http://hg.mozilla.org/releases/mozilla-aurora/rev/2dbc5865a159