657755 - [PATCH] Missing close button for Event dialog under Gnome3

Status: RESOLVED FIXED

(Calendar :: Dialogs, defect)

Description

[Alexandre Demers]

User-Agent:       Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/534.35 (KHTML, like Gecko) Chrome/13.0.762.0 Safari/534.35
Build Identifier: 1.0b2

When opening an event in the calendar, there is no Close button available to use if nothing was changed. We have to go through Edit -> Close. Since we may want to have a quick look at an event without editing it, there should be a close button.

Reproducible: Always

Steps to Reproduce:
Open an event. Look at the window.

Actual Results:  
There is no close button. We have to go through Edit -> Close

Expected Results:  
There should be a close button.

Comment 1

[Philipp Preißer-Kewisch [:Fallen][☁️📆]]

You mean a toolbarbutton? What about just closing the window using the OS controls?

Comment 2

[Alexandre Demers]

I don't mean a toolbar button. I'd like to use the OS controls, but there is none available for that dialog, well under Gnome at least (look at the screenshot I'm adding). I'll check under Windows and add more info.

Comment 3

[Alexandre Demers]

Attachment: Event dialog

Comment 4

[Alexandre Demers]

I checked under Windows and KDE and both show a close button. So it only applies to Gnome (I'm using Gnome 3, so it may not even apply to Gnome 2).

Comment 5

[Philipp Preißer-Kewisch [:Fallen][☁️📆]]

This doesn't apply to gnome 2. I don't think we should add a toolbarbutton extra for this purpose, but find out why the OS buttons are gone and try to get them back.

Comment 6

[Alexandre Demers]

I agree with you. In fact, this is why I renamed the bug.

Comment 7

[Alexandre Demers]

It seems related with how Gnome 3 handles some kind of windows, particularly dialog window. This may be a clue: http://mail.gnome.org/archives/gnome-shell-list/2011-May/msg00272.html

Comment 8

[Pascal Chevrel (relman team) -> :pascalc]

see bug 608934 for the Firefox equivalent of this bug

Comment 9

[Stefan Sitter [:ssitter]]

Maybe we can use a similar workaround as in Bug 662244.

Comment 10

[Alexandre Demers]

Attachment: make sure close button's available for event dialog

As stated, there is no close button under Gnome3 for dialog. I just used the same trick applied for the "About" dialog.

Comment 11

[Martin Schröder [:mschroeder]]

Why should we override the default behavior of the GNOME3 desktop which seems to behave unexpectedly? Adding workaround to our code, like that one proposed, does not seem like the correct approach to me.

Comment 12

[Alexandre Demers]

While I do agree with you, it seems Gnome devs think differently about how a dialog window should be used and what it should be. Please, see link in comment 7 and bug 662244 for more info on the subject. If you have a different solution to propose,  you are welcome to do it and I'll be happy to help you implement it.

Comment 13

[Philipp Preißer-Kewisch [:Fallen][☁️📆]]

Comment on attachment 578495 [details] [diff] [review]
make sure close button's available for event dialog

r=philipp

Comment 14

[Philipp Preißer-Kewisch [:Fallen][☁️📆]]

Oh this has needed checkin for a while now, sorry. I've decided to slightly change the code to avoid the need for the preprocessor in this file. See the following revision on hg for details

Comment 15

[Philipp Preißer-Kewisch [:Fallen][☁️📆]]

Pushed to comm-central changeset f7d035d67962