Last Comment Bug 657780 - FrameLayerBuilder warning pldhash
: FrameLayerBuilder warning pldhash
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Graphics (show other bugs)
: Trunk
: All All
: -- major (vote)
: mozilla6
Assigned To: Robert O'Callahan (:roc) (email my personal email if necessary)
:
Mentors:
Depends on:
Blocks: fx-noise
  Show dependency treegraph
 
Reported: 2011-05-17 14:37 PDT by Benjamin Stover (:stechz)
Modified: 2011-05-18 04:17 PDT (History)
7 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
fix (11.14 KB, patch)
2011-05-17 16:49 PDT, Robert O'Callahan (:roc) (email my personal email if necessary)
tnikkel: review+
Details | Diff | Splinter Review
fix v2 (11.50 KB, patch)
2011-05-17 22:46 PDT, Robert O'Callahan (:roc) (email my personal email if necessary)
roc: review+
Details | Diff | Splinter Review

Description Benjamin Stover (:stechz) 2011-05-17 14:37:50 PDT
On Fennec with every mousemove I get the warning:
pldhash: for the table at address %p, the given entrySize of 84 definitely favors chaining over double hashign.

The key for a ThebesLayerItemsEntry is rather large at the size of 84 bytes. This seems like a pretty enormous key. Perhaps the key should be a pointer to this data?
Comment 1 Kyle Huey [:khuey] (Exited; not receiving bugmail, email if necessary) 2011-05-17 15:23:43 PDT
This happens on Firefox too.
Comment 2 Kyle Huey [:khuey] (Exited; not receiving bugmail, email if necessary) 2011-05-17 15:39:33 PDT
FWIW, the spam here is severe enough that I'd consider backing out the patch that introduced this.
Comment 3 Robert O'Callahan (:roc) (email my personal email if necessary) 2011-05-17 16:49:54 PDT
Created attachment 533116 [details] [diff] [review]
fix
Comment 4 Timothy Nikkel (:tnikkel) 2011-05-17 22:43:17 PDT
Comment on attachment 533116 [details] [diff] [review]
fix

   /**
    * Save aMatrix as the transform that was in aLayer when we last painted.
    */
-  void SaveLastPaintTransform(ThebesLayer* aLayer, const gfx3DMatrix& aMatrix);
+  void SaveLastPaintOffset(ThebesLayer* aLayer);
   /**
    * Get the transform that was in aLayer when we last painted. It's either
    * the transform saved by SaveLastPaintTransform, or else the transform
    * that's currently in the layer.
    */
-  const gfx3DMatrix& GetLastPaintTransform(ThebesLayer* aLayer);
+  nsIntPoint GetLastPaintOffset(ThebesLayer* aLayer);

The comments need updating here.
Comment 5 Robert O'Callahan (:roc) (email my personal email if necessary) 2011-05-17 22:46:33 PDT
Created attachment 533183 [details] [diff] [review]
fix v2
Comment 6 Robert O'Callahan (:roc) (email my personal email if necessary) 2011-05-17 22:50:19 PDT
http://hg.mozilla.org/projects/cedar/rev/a519b72356bf
Comment 7 Mounir Lamouri (:mounir) 2011-05-18 02:53:35 PDT
Pushed:
http://hg.mozilla.org/mozilla-central/rev/a519b72356bf

Note You need to log in before you can comment on or make changes to this bug.