FrameLayerBuilder warning pldhash

RESOLVED FIXED in mozilla6

Status

()

Core
Graphics
--
major
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: stechz, Assigned: roc)

Tracking

(Blocks: 1 bug)

Trunk
mozilla6
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

6 years ago
On Fennec with every mousemove I get the warning:
pldhash: for the table at address %p, the given entrySize of 84 definitely favors chaining over double hashign.

The key for a ThebesLayerItemsEntry is rather large at the size of 84 bytes. This seems like a pretty enormous key. Perhaps the key should be a pointer to this data?
This happens on Firefox too.
FWIW, the spam here is severe enough that I'd consider backing out the patch that introduced this.
Severity: normal → major
Created attachment 533116 [details] [diff] [review]
fix
Assignee: nobody → roc
Attachment #533116 - Flags: review?(tnikkel)
Comment on attachment 533116 [details] [diff] [review]
fix

   /**
    * Save aMatrix as the transform that was in aLayer when we last painted.
    */
-  void SaveLastPaintTransform(ThebesLayer* aLayer, const gfx3DMatrix& aMatrix);
+  void SaveLastPaintOffset(ThebesLayer* aLayer);
   /**
    * Get the transform that was in aLayer when we last painted. It's either
    * the transform saved by SaveLastPaintTransform, or else the transform
    * that's currently in the layer.
    */
-  const gfx3DMatrix& GetLastPaintTransform(ThebesLayer* aLayer);
+  nsIntPoint GetLastPaintOffset(ThebesLayer* aLayer);

The comments need updating here.
Attachment #533116 - Flags: review?(tnikkel) → review+
Created attachment 533183 [details] [diff] [review]
fix v2
Attachment #533183 - Flags: review+
Attachment #533116 - Attachment is obsolete: true
Keywords: checkin-needed
http://hg.mozilla.org/projects/cedar/rev/a519b72356bf
Whiteboard: fixed-in-cedar
Pushed:
http://hg.mozilla.org/mozilla-central/rev/a519b72356bf
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Whiteboard: fixed-in-cedar
Target Milestone: --- → mozilla6

Updated

6 years ago
Blocks: 341986
You need to log in before you can comment on or make changes to this bug.