657981 - runtestremote change for --pidfile and --enablePrivilege parameters need to land on mozilla-beta

Status: RESOLVED FIXED

(Testing :: General, defect)

Description

[Joel Maher ( :jmaher ) (UTC -8)]

these changes are in m-c and partially on m-a, but are required for us to run jsreftests.

Comment 1

[Joel Maher ( :jmaher ) (UTC -8)]

Attachment: add --pidfile and --enable-privilege to mozilla-beta for android testing (1.0)

this patch only affects android tegra testing and will enable us to run jsreftests as they are almost ready to turn on.  In addition this adds a pidfile option so we can cleanup zombie processes if they exist.

Comment 2

[cmtalbert]

Mozilla-beta right now is Firefox 5, re-setting flags properly.

Comment 3

[cmtalbert]

Comment on attachment 533364 [details] [diff] [review]
add --pidfile and --enable-privilege to mozilla-beta for android testing (1.0)

Review of attachment 533364 [details] [diff] [review]:
-----------------------------------------------------------------

These look good for m-beta.

Comment 4

[Asa Dotzler [:asa]]

Please request approvals using the attachment flag approval-mozilla-beta? and not the tracking flags. Thanks.

Comment 5

[Joel Maher ( :jmaher ) (UTC -8)]

I cannot find any flags to set related to the attachment, the only flags I see are for review, feedback, addl review.

Comment 6

[Johnathan Nightingale [:johnath]]

Bleah - yeah, sorry Joel, this component doesn't have those flags available - we'll process it in tracking triage and give you an approval in comments. (Is it worth you or Clint finding out how to get the flags added to this product? Are there likely to be more bugs like this?)

Comment 7

[Joel Maher ( :jmaher ) (UTC -8)]

Thanks for the info.

I would assume there will be a few random bugs that we need to get landed across the branches, but not a large frequency.  If it isn't too difficult, it might make sense to add these flags to the testing component since we do have a lot of little harnesses and tools.  These specific bugs are because we are fine tuning the android tests and turning on jsreftests for the first time.

Comment 8

[cmtalbert]

(In reply to comment #7)
> Thanks for the info.
> 
> I would assume there will be a few random bugs that we need to get landed
> across the branches, but not a large frequency.  If it isn't too difficult,
> it might make sense to add these flags to the testing component since we do
> have a lot of little harnesses and tools.  These specific bugs are because
> we are fine tuning the android tests and turning on jsreftests for the first
> time.

I think there will always be a couple of these on some very low frequency basis as the test harness infrastructure needs to adapt to product changes. We'll likely see most of these anytime we're bringing a new test harness online (like android).  Filed bug 659096 so we can get the proper flags setup.

Comment 9

[Johnathan Nightingale [:johnath]]

Clearing the nom - discussed in triage - a=me to land wherever you need it on the assumption that it's test only and easy to back out.

Comment 10

[Joel Maher ( :jmaher ) (UTC -8)]

http://hg.mozilla.org/releases/mozilla-beta/rev/23d449276096