658017 - Flag the chrome namespace 'godlikea'

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Admin/Editor Tools, defect, P3)

Description

[Kris Maglione [:kmag]]

User-Agent:       Mozilla/5.0 (X11; Linux x86_64; rv:6.0a1) Gecko/20110419 Firefox/6.0a1
Build Identifier: 

I thought I'd reported this ages ago, but apparently not.

There's a web tutorial for a simple add-on which encourages users to copy its template and make certain modifications. Among those modifications is not, however, the chrome namespace. As a result, we've received several dozen submissions that all use the nonsensical chrome namespace 'godlikea'.

It would be a good idea to flag any specifications of that namespace in chrome.manifest. I think this should probably be a hard error. It might be a good idea to have a banned namespaces list, and include this along with 'modules' as introduced in a previous bug.

Reproducible: Always

Comment 1

[Wil Clouser [:clouserw]]

What is the error message?

Comment 2

[Kris Maglione [:kmag]]

Shouldn't matter much, so long as it says that the namespace is banned. Whatever the current error message for the 'modules' namespace is should do. I guess I'd go with something like “The namespace '%s' is banned. Please choose a namespace unique to your add-on.”

Comment 3

[Jorge Villalobos [:jorgev] (he/him)]

I think it should be something like: "The 'godlikea' chrome namespace is generated from a template and should be replaced with something unique to your add-on to avoid name conflicts."

Comment 4

[Matt Basta [:basta]]

Fixed:

https://github.com/mozilla/amo-validator/pull/45

Comment 5

[Matt Basta [:basta]]

Merged:

https://github.com/mozilla/amo-validator/commit/04e51eec87b4fd491b618ac124dfe23583732c88

Comment 6

[krupa raj[:krupa]]

Filed bug 661279

chrome namespace 'godlikea' will cause the validation to fail.

Comment 7

[krupa raj[:krupa]]

Attachment: post-fix screenshot

verified at https://addons-next.allizom.org/en-US/developers/upload/a8d45cb188b3487c9ce8e5b617da3819