658034 - AJAX-loading spinner images still display after we return a 500 Internal Server Error for reports

Status: VERIFIED FIXED

(Socorro :: General, task, P1)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

STR:

With the Web Console open, load https://crash-stats-dev.allizom.org/topcrasher/byversion/Firefox/5.0 and wait

Expected Results:

Even though the AJAX calls are returning a 500 Internal Server Error (separate issue [1]), the AJAXy "Loading" animated GIFs should stop spinning/disappear once we return 500

Actual Results:

They keeep spinning

[1]:

[13:02:12.444] POST https://crash-stats-dev.allizom.org/correlation/bulk_ajax/cpu/Firefox/5.0/
[13:02:12.469] POST https://crash-stats-dev.allizom.org/correlation/bulk_ajax/addon/Firefox/5.0/
[13:02:12.490] POST https://crash-stats-dev.allizom.org/correlation/bulk_ajax/module/Firefox/5.0/

Comment 1

[Robert Helmer [:rhelmer]]

Attachment: replace spinners w/ error message

Comment 2

[Laura Thomson :laura]

Land ASAP please.

Comment 3

[Robert Helmer [:rhelmer]]

Committed revision 3182.

Comment 4

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Post-fix screenshot

Comment 5

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED on https://crash-stats-dev.allizom.org/topcrasher/byversion/Firefox/4.0/7/all.