Closed Bug 658052 Opened 13 years ago Closed 13 years ago

Search page doesn't validate

Categories

(addons.mozilla.org Graveyard :: Add-on Builder, defect)

Product:
addons.mozilla.org Graveyard
Component:
Add-on Builder
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
VERIFIED FIXED
Milestone:
Builder 0.9.6

People

(Reporter: stephend, Assigned: rfreebern)

References

(
URL
)

Details

https://builder.addons.mozilla.org/search/ doesn't validate:

http://html5.validator.nu/?doc=https%3A%2F%2Fbuilder.addons.mozilla.org%2Fsearch%2F

    Error: Bad value for attribute id on element body: An ID must not be the empty string.

    From line 64, column 2; to line 64, column 13

    </head>↩ <body id="">↩ ↩

    Syntax of id:
        An ID consists of at least one character but must not contain any whitespace. 

    Error: Element h2 not allowed as child of element label in this context. (Suppressing further errors from this subtree.)

    From line 119, column 6; to line 119, column 9

    bel>↩ <h2>Enter

    Content model for element label:
        Phrasing content, but with no descendant labelable form-associated elements unless it is the element's labeled control, and no descendant label elements.
Assignee: nobody → ryan
(In reply to comment #1)
> https://github.com/rfreebern/FlightDeck/commit/
> 16981f2117ccdc9977e8cc0c0e1141d900385ad0

Still getting validation errors on http://html5.validator.nu/?doc=https%3A%2F%2Fbuilder-addons.allizom.org%2F, sadly :-(
 (In reply to comment #2)
> Still getting validation errors on
> http://html5.validator.nu/?doc=https%3A%2F%2Fbuilder-addons.allizom.org%2F,
> sadly :-(

Comment 0 specifically referred to the search page, so that's what I focused on. Also, my commit hasn't been merged yet, so it's not affecting trunk. However, the "bad value for attribute rel" is going to affect any page where the "test" button appears, which includes the search results page, the homepage, the dashboard, and others.

Instead of using rel for the jid value, maybe we should be using data-jetpackid?
Yeah, sorry, you're right, Ryan -- can't believe I missed that (and it's my own bug, too, sigh; I chalk it up to just coming back from vacation).

I'll retest on http://html5.validator.nu/?doc=https%3A%2F%2Fbuilder-addons.allizom.org%2Fsearch when your commit has been merged in, and the bug has been marked FIXED; thanks!
Trunk is updating again, and I've verified that http://html5.validator.nu/?doc=https%3A%2F%2Fbuilder-addons.allizom.org%2Fsearch is reporting no problems, so I'm closing this bug. Should I file a separate bug regarding the rel="jid..." issue?
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Verified FIXED on http://html5.validator.nu/?doc=https%3A%2F%2Fbuilder-addons.allizom.org%2Fsearch%2F.

Ryan, yeah, please do file (in response to comment 6); thanks for fixing!
Status: RESOLVED → VERIFIED
Target Milestone: --- → Builder 0.9.5
(In reply to comment #7)
> Ryan, yeah, please do file (in response to comment 6); thanks for fixing!

Sure thing. Please see bug 663472.
Target Milestone: Builder 0.9.5 → Builder 0.9.6
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.