Rename GlobalObject::isEvalAllowed

RESOLVED FIXED in mozilla7

Status

()

Core
JavaScript Engine
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Waldo, Assigned: Waldo)

Tracking

unspecified
mozilla7
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: fixed-in-tracemonkey)

Attachments

(1 attachment)

It's really something like "is dynamic code generation possible via eval or Function", so its name is a misnomer (particularly when it's called in the code to implement the Function constructor!).

Tangentially, but perhaps fixable in this bug, we should get rid of js_CheckContentSecurityPolicy, and we should make all such callers use the GlobalObject::* method instead.
Created attachment 538311 [details] [diff] [review]
Patch
Attachment #538311 - Flags: review?(mrbkap)

Updated

6 years ago
Attachment #538311 - Flags: review?(mrbkap) → review+
http://hg.mozilla.org/tracemonkey/rev/ec6d95dc5e1c
Status: NEW → ASSIGNED
Whiteboard: fixed-in-tracemonkey
Target Milestone: --- → mozilla7
cdleary-bot mozilla-central merge info:
http://hg.mozilla.org/mozilla-central/rev/ec6d95dc5e1c
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.