Last Comment Bug 658069 - Rename GlobalObject::isEvalAllowed
: Rename GlobalObject::isEvalAllowed
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: unspecified
: All All
-- normal (vote)
: mozilla7
Assigned To: Jeff Walden [:Waldo] (remove +bmo to email)
: Jason Orendorff [:jorendorff]
Depends on:
  Show dependency treegraph
Reported: 2011-05-18 14:29 PDT by Jeff Walden [:Waldo] (remove +bmo to email)
Modified: 2011-06-20 17:03 PDT (History)
1 user (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

Patch (4.98 KB, patch)
2011-06-09 12:07 PDT, Jeff Walden [:Waldo] (remove +bmo to email)
mrbkap: review+
Details | Diff | Splinter Review

Description User image Jeff Walden [:Waldo] (remove +bmo to email) 2011-05-18 14:29:29 PDT
It's really something like "is dynamic code generation possible via eval or Function", so its name is a misnomer (particularly when it's called in the code to implement the Function constructor!).

Tangentially, but perhaps fixable in this bug, we should get rid of js_CheckContentSecurityPolicy, and we should make all such callers use the GlobalObject::* method instead.
Comment 1 User image Jeff Walden [:Waldo] (remove +bmo to email) 2011-06-09 12:07:29 PDT
Created attachment 538311 [details] [diff] [review]
Comment 2 User image Jeff Walden [:Waldo] (remove +bmo to email) 2011-06-13 18:19:20 PDT
Comment 3 User image Chris Leary [:cdleary] (not checking bugmail) 2011-06-20 17:03:52 PDT
cdleary-bot mozilla-central merge info:

Note You need to log in before you can comment on or make changes to this bug.