Closed Bug 658081 Opened 9 years ago Closed 8 years ago

nsNavBookmarks.cpp build warnings for "nsNavBookmarks::SetItemGUID ... is deprecated" and "nsNavBookmarks::GetItemIdForGUID ... is deprecated"

Categories

(Toolkit :: Places, defect)

defect
Not set

Tracking

()

RESOLVED WORKSFORME

People

(Reporter: dholbert, Unassigned)

References

(Blocks 1 open bug, )

Details

(Whiteboard: [build_warning])

Filing bug on this warning:
{
../../../../toolkit/components/places/nsNavBookmarks.cpp: In member function 'virtual nsresult nsNavBookmarks::GetItemGUID(PRInt64, nsAString_internal&)':
../../../../toolkit/components/places/nsNavBookmarks.cpp:2035:34: warning: 'virtual nsresult nsNavBookmarks::SetItemGUID(PRInt64, const nsAString_internal&)' is deprecated (declared at ../../../../toolkit/components/places/nsNavBookmarks.h:124)
../../../../toolkit/components/places/nsNavBookmarks.cpp: In member function 'virtual nsresult nsNavBookmarks::SetItemGUID(PRInt64, const nsAString_internal&)':
../../../../toolkit/components/places/nsNavBookmarks.cpp:2047:35: warning: 'virtual nsresult nsNavBookmarks::GetItemIdForGUID(const nsAString_internal&, PRInt64*)' is deprecated (declared at ../../../../toolkit/components/places/nsNavBookmarks.h:124)
}
(excerpted from the build log in URL field)

Basically:
* nsNavBookmarks calls its own method SetItemGUID, from within GetItemGUID
* nsNavBookmarks calls its own method GetItemIdForGUID, from within SetItemGUID
* Both of those methods were flagged as deprecated in this cset:
    http://hg.mozilla.org/mozilla-central/rev/325173c0f7e9#l1.24
...but these calls remain, so now we spam "is deprecated" warnings when building nsNavBookmarks.cpp.
OS: Linux → All
Hardware: x86_64 → All
I think Shawn has a patch for this in another bug about warnings (Maybe was the one in Storage that has the same problem), but at the same time Bsmedberg said we should not use [deprecate], even if reasons are still tbd (main reason was warnings that we can fix with compiler pragmas).
So finally all of the process hanged due to more important stuff to be worked on.
There is no such warnings in current head of m-c. https://tbpl.mozilla.org/php/getParsedLog.php?id=6268962&full=1

Hence closing this bug.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.