Closed Bug 658083 Opened 13 years ago Closed 13 years ago

update verify config bumper needs to not use pretty versions any more

Categories

(Release Engineering :: General, defect, P2)

x86
macOS
defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: nthomas, Assigned: bhearsum)

References

Details

Attachments

(2 files)

This 
 from="/firefox/releases/5.0b1/win32/%locale%/Firefox Setup 5.0 Beta 1.exe"
should be 
 from="/firefox/releases/5.0b1/win32/%locale%/Firefox Setup 5.0b2.exe"

Similar to bug 657882. Breaks mac and windows update verify for 5.0b1 -> 5.0b2.
This will make the update verify work for 5.0b2 on mac and windows.
Attachment #533441 - Flags: review?(lsblakk)
To fix the bumper script we'll need to stop passing it 
  '--long-version=5.0 Beta 2'  '--old-long-version=5.0 Beta 1'
Attachment #533441 - Flags: review?(lsblakk) → review+
Comment on attachment 533441 [details] [diff] [review]
[tools] Fix update verify configs for 5.0b2

http://hg.mozilla.org/build/tools/rev/178080760b1a
Attachment #533441 - Flags: checked-in+
Blocks: 660940
Nick, I owe you at least one, I'll take this.
Assignee: nrthomas → bhearsum
I decided to maintain support for the old versions, just in case we (or another consumer like Thunderbird or SeaMonkey) need it. However, ReleaseUpdatesFactory now defaults to the short version, and I didn't update the repack factory because it's deprecated.

Needs testing before review.
Comment on attachment 536418 [details] [diff] [review]
default long versions to version/oldVersion

This worked fine in my staging run:
http://hg.mozilla.org/users/bhearsum_mozilla.com/tools/rev/405270aeabb9
Attachment #536418 - Flags: review?(nrthomas)
Comment on attachment 536418 [details] [diff] [review]
default long versions to version/oldVersion

So people like SeaMonkey still using mozilla-2.0 will need to set longVersion and oldLongVersion in the release config, but we don't for any current Firefox releases ?
Attachment #536418 - Flags: review?(nrthomas) → review+
Yeah, exactly.
Comment on attachment 536418 [details] [diff] [review]
default long versions to version/oldVersion

Landed on default, will head to production when 5.0b4 starts.
Attachment #536418 - Flags: checked-in+
Worked fine in 5.0b4
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: